Source/build/scripts/make_style_builder.py - Issue 415613002: Merge CSSPropertyNames.in and SVGCSSPropertyNames.in with CSSProperties.in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/build/scripts/make_style_builder.py

Issue 415613002: Merge CSSPropertyNames.in and SVGCSSPropertyNames.in with CSSProperties.in (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/build/scripts/make_style_builder.py

diff --git a/Source/build/scripts/make_style_builder.py b/Source/build/scripts/make_style_builder.py

index d0367b8f495301c37cc4cc270eff3015e234c160..e6ec5fa8f768d4d2fafa5c906270246b06eaf7d1 100755

--- a/Source/build/scripts/make_style_builder.py

+++ b/Source/build/scripts/make_style_builder.py

@@ -63,8 +63,9 @@ class StyleBuilderWriter(css_properties.CSSProperties):

property['custom_initial'] = True

property['custom_inherit'] = True

property['custom_value'] = True

- property['should_declare_functions'] = not property['use_handlers_for'] and not property['longhands'] \

- and not property['direction_aware'] and not property['builder_skip']

+ if property['longhands'] or property['use_handlers_for'] or property['direction_aware']:

+ property['builder_unreachable'] = True

+ property['should_declare_functions'] = not property['builder_unreachable'] and not property['builder_skip']

self._properties['CSSPropertyFont']['should_declare_functions'] = True

« Source/build/scripts/css_properties.py ('K') | « Source/build/scripts/make_css_property_names.py ('k') | Source/core/BUILD.gn » ('j') | no next file with comments »