Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 415543002: Express LoadIC extra ic state with LoadIC::State (Closed)

Created:
6 years, 5 months ago by mvstanton
Modified:
6 years, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Express LoadIC extra ic state with LoadIC::State Soon we will create code stubs that need to match LoadIC state. It's easier to express if the state is encapsulated in a single class rather than multiple bit fields. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22559

Patch Set 1 #

Patch Set 2 : Code comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M src/ic.h View 1 2 chunks +24 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
HI Toon, Here is the change we discussed. I will revisit eliminating ContextualMode later. thx, ...
6 years, 5 months ago (2014-07-23 11:56:46 UTC) #1
Toon Verwaest
lgtm
6 years, 5 months ago (2014-07-23 12:17:50 UTC) #2
mvstanton
6 years, 5 months ago (2014-07-23 12:24:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22559.

Powered by Google App Engine
This is Rietveld 408576698