Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 415533002: Add a UseCounter for HTMLPreElement.width (Closed)

Created:
6 years, 5 months ago by philipj_slow
Modified:
6 years, 5 months ago
CC:
arv+blink, blink-reviews, blink-reviews-html_chromium.org, Inactive, dglazkov+blink
Project:
blink
Visibility:
Public.

Description

Add a UseCounter for HTMLPreElement.width The content attribute has no effect, so this API is completely useless. It is widely implemented, but was removed from spec, so attempting removal seems worthwhile, as it could leave HTMLPreElement empty. http://whatwg.org/html#the-pre-element Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178773

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLPreElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
6 years, 5 months ago (2014-07-23 11:53:25 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-23 15:20:21 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 5 months ago (2014-07-23 15:24:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/415533002/1
6 years, 5 months ago (2014-07-23 15:25:53 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 16:51:37 UTC) #5
Message was sent while issue was closed.
Change committed as 178773

Powered by Google App Engine
This is Rietveld 408576698