Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 41553003: Downloads: Avoid some redundant map lookups in DownloadMangerImpl. (Closed)

Created:
7 years, 2 months ago by Lei Zhang
Modified:
7 years, 1 month ago
CC:
chromium-reviews, benjhayden+dwatch_chromium.org, asanka, darin-cc_chromium.org, jam, joi+watch-content_chromium.org
Visibility:
Public.

Description

Downloads: Avoid some redundant map lookups in DownloadMangerImpl. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231469

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M content/browser/download/download_manager_impl.cc View 1 5 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Lei Zhang
7 years, 2 months ago (2013-10-24 21:32:04 UTC) #1
Randy Smith (Not in Mondays)
LGTM. Do you have some evidence that this is actually causing performance problems? There are ...
7 years, 1 month ago (2013-10-25 17:10:38 UTC) #2
Lei Zhang
No performance issue concerns. I put back a couple of the ContainsKeys() since it is ...
7 years, 1 month ago (2013-10-25 22:49:06 UTC) #3
Randy Smith (Not in Mondays)
Awesome; thanks. Still LGTM.
7 years, 1 month ago (2013-10-28 14:29:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/41553003/50001
7 years, 1 month ago (2013-10-28 18:26:05 UTC) #5
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=96478
7 years, 1 month ago (2013-10-28 19:12:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/41553003/50001
7 years, 1 month ago (2013-10-28 20:31:31 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-10-29 01:07:45 UTC) #8
Message was sent while issue was closed.
Change committed as 231469

Powered by Google App Engine
This is Rietveld 408576698