Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5455)

Unified Diff: chrome/browser/chromeos/options/wifi_config_view.cc

Issue 415483002: Pass slot id to Shill for manually configured WiFi with EAP-TLS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/options/cert_library.cc ('k') | chromeos/network/client_cert_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/options/wifi_config_view.cc
diff --git a/chrome/browser/chromeos/options/wifi_config_view.cc b/chrome/browser/chromeos/options/wifi_config_view.cc
index c328ca1d1c7bb812b9888f647240281d0c8538a0..a0119a772bce6b1e6b6248e65001fead38c534ef 100644
--- a/chrome/browser/chromeos/options/wifi_config_view.cc
+++ b/chrome/browser/chromeos/options/wifi_config_view.cc
@@ -14,6 +14,7 @@
#include "chrome/browser/chromeos/options/passphrase_textfield.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "chromeos/login/login_state.h"
+#include "chromeos/network/client_cert_util.h"
#include "chromeos/network/network_configuration_handler.h"
#include "chromeos/network/network_event_log.h"
#include "chromeos/network/network_handler.h"
@@ -872,12 +873,12 @@ void WifiConfigView::SetEapProperties(base::DictionaryValue* properties) {
properties->SetStringWithoutPathExpansion(
shill::kEapSubjectMatchProperty, GetEapSubjectMatch());
- // shill requires both CertID and KeyID for TLS connections, despite
- // the fact that by convention they are the same ID.
- properties->SetStringWithoutPathExpansion(
- shill::kEapCertIdProperty, GetEapClientCertPkcs11Id());
- properties->SetStringWithoutPathExpansion(
- shill::kEapKeyIdProperty, GetEapClientCertPkcs11Id());
+ const std::string pkcs11id = GetEapClientCertPkcs11Id();
+ client_cert::SetShillProperties(client_cert::CONFIG_TYPE_EAP,
+ CertLibrary::Get()->GetTPMSlotID(),
+ TPMTokenLoader::Get()->tpm_user_pin(),
+ &pkcs11id,
+ properties);
properties->SetBooleanWithoutPathExpansion(
shill::kEapUseSystemCasProperty, GetEapUseSystemCas());
« no previous file with comments | « chrome/browser/chromeos/options/cert_library.cc ('k') | chromeos/network/client_cert_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698