Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 415483002: Pass slot id to Shill for manually configured WiFi with EAP-TLS. (Closed)

Created:
6 years, 5 months ago by pneubeck (no reviews)
Modified:
6 years, 5 months ago
Reviewers:
stevenjb, pastarmovj
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Pass slot id to Shill for manually configured WiFi with EAP-TLS. Before, wifi_config_view directly set the shill::kEapCertIdProperty and shill::kEapKeyIdProperty. Since the system token is enabled in ChromeOS, these properties have to be of the format '<slot_id>:<key_id>' and not only '<key_id>'. This change fixes this by reusing the client_cert::SetShillProperties function, which sets the properties in the correct format. R=pastarmovj@chromium.org TBR=stevenjb@chromium.org BUG=358366, 396181 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M chrome/browser/chromeos/options/cert_library.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/options/cert_library.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M chromeos/network/client_cert_util.h View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
pneubeck (no reviews)
please take a look.
6 years, 5 months ago (2014-07-23 09:47:47 UTC) #1
pneubeck (no reviews)
6 years, 5 months ago (2014-07-23 10:12:27 UTC) #2
pastarmovj
lgtm
6 years, 5 months ago (2014-07-23 10:21:12 UTC) #3
pneubeck (no reviews)
The CQ bit was checked by pneubeck@chromium.org
6 years, 5 months ago (2014-07-23 10:34:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/415483002/1
6 years, 5 months ago (2014-07-23 10:34:59 UTC) #5
pneubeck (no reviews)
The CQ bit was unchecked by pneubeck@chromium.org
6 years, 5 months ago (2014-07-23 12:34:42 UTC) #6
pneubeck (no reviews)
The CQ bit was checked by pneubeck@chromium.org
6 years, 5 months ago (2014-07-23 12:50:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/415483002/1
6 years, 5 months ago (2014-07-23 12:52:46 UTC) #8
pneubeck (no reviews)
The CQ bit was unchecked by pneubeck@chromium.org
6 years, 5 months ago (2014-07-23 14:11:30 UTC) #9
pneubeck (no reviews)
Committed patchset #1 manually as r284914 (presubmit successful).
6 years, 5 months ago (2014-07-23 14:12:12 UTC) #10
stevenjb
6 years, 5 months ago (2014-07-23 16:36:32 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698