Disable remaining test on Mac that is flaking more than 5%.

chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 
 #include "base/mac/mac_util.h"
 #import "base/mac/scoped_nsobject.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/prefs/pref_service.h"
@@ skipping 824 matching lines @@
 
   [controller_ enterFullscreen];
   WaitForFullScreenTransition();
   EXPECT_TRUE([controller_ isFullscreen]);
 
   [controller_ exitFullscreen];
   WaitForFullScreenTransition();
   EXPECT_FALSE([controller_ isFullscreen]);
 }
 
 // If this test fails, it is usually a sign that the bots have some sort of

[viettrungluu, 2014/07/23 15:16:34]

Hmmm. This comment is worth reading and investigating, maybe.

[jam, 2014/07/23 15:20:04]

when disabling flaky tests, we don't have the bandwidth to investigate tests on
authors behalf.. given that it's flaking 5% of the time, the test needs to be
changed to handle this error condition

[viettrungluu, 2014/07/23 15:51:33]

Fair enough, but how recent is the flakiness? (Could it be a more recent bot
issue? The bug that you labelled it with dates from 2010.)

Could you at least assign an owner for the bug to investigate?

[jam, 2014/07/23 15:55:42]

That data is continuously updated, so it's recent.
done

 // problem (such as a modal dialog up).  This tests is a very useful canary, so
 // please do not mark it as flaky without first verifying that there are no bot
 // problems.
-TEST_F(BrowserWindowFullScreenControllerTest, TestActivate) {
+// http://crbug.com/53586
+TEST_F(BrowserWindowFullScreenControllerTest, DISABLED_TestActivate) {
   [controller_ showWindow:nil];
 
   EXPECT_FALSE([controller_ isFullscreen]);
 
   [controller_ activate];
   EXPECT_TRUE(IsFrontWindow([controller_ window]));
 
   [controller_ enterFullscreen];
   WaitForFullScreenTransition();
   [controller_ activate];
@@ skipping 21 matching lines @@
       [[NSWindow alloc] initWithContentRect:NSMakeRect(0,0,400,400)
                                   styleMask:NSBorderlessWindowMask
                                     backing:NSBackingStoreBuffered
                                       defer:NO]);
   [[testFullscreenWindow_ contentView] cr_setWantsLayer:YES];
   return testFullscreenWindow_.get();
 }
 @end
 
 /* TODO(???): test other methods of BrowserWindowController */