Turn webspeech on/off when tab goes fore/background

Turn webspeech off when tab goes background

This change adds a toggle to turn webspeech off when tab goes background.
And further request to turn media capture devices on will be denied.
So Both WebRTC and webSpeech won't be able to initiate new requests when tab is in background.

BUG=396054
R=dalecurtis@chromium.org, jam@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285072

[qinmin, 2014-07-23 02:17:43]

PTAL, please prioritize this, thanks

[juberti2, 2014-07-23 03:01:43]

On 2014/07/23 02:17:43, qinmin wrote:
> PTAL, please prioritize this, thanks

Shijing is in a better position to review than me.

[no longer working on chromium, 2014-07-23 09:38:37]

Lets continue our discussion in the bug thread before we get into the review
details, and honestly I am not convinced we should change the start() method
from void to bool.

[qinmin, 2014-07-23 22:08:46]

Reviewers/OWNERs, this CL is now ready for review. It addresses both the issue
in webrtc and webspeech. Please take a look

[DaleCurtis, 2014-07-23 22:17:19]

media/ lgtm

https://codereview.chromium.org/415433002/diff/20001/chrome/browser/media/med...
File chrome/browser/media/media_stream_devices_controller.cc (left):

https://codereview.chromium.org/415433002/diff/20001/chrome/browser/media/med...
chrome/browser/media/media_stream_devices_controller.cc:31: 
Line break is normally kept here.

https://codereview.chromium.org/415433002/diff/20001/chrome/browser/media/med...
File chrome/browser/media/media_stream_devices_controller.cc (right):

https://codereview.chromium.org/415433002/diff/20001/chrome/browser/media/med...
chrome/browser/media/media_stream_devices_controller.cc:661: bool
MediaStreamDevicesController::IsDeviceAudioCaptureRequestedAndAllowed()
Presumably all three of these methods are being called on the UI thread only?

[DaleCurtis, 2014-07-23 22:18:43]

Is it possible to write a test for this in a follow up CL?

[qinmin, 2014-07-23 22:28:49]

Added a TODO for a follow up test.
http://crbug.com/396869

https://codereview.chromium.org/415433002/diff/20001/chrome/browser/media/med...
File chrome/browser/media/media_stream_devices_controller.cc (left):

https://codereview.chromium.org/415433002/diff/20001/chrome/browser/media/med...
chrome/browser/media/media_stream_devices_controller.cc:31: 
On 2014/07/23 22:17:19, DaleCurtis wrote:
> Line break is normally kept here.

Done.

https://codereview.chromium.org/415433002/diff/20001/chrome/browser/media/med...
File chrome/browser/media/media_stream_devices_controller.cc (right):

https://codereview.chromium.org/415433002/diff/20001/chrome/browser/media/med...
chrome/browser/media/media_stream_devices_controller.cc:661: bool
MediaStreamDevicesController::IsDeviceAudioCaptureRequestedAndAllowed()
Yes.

On 2014/07/23 22:17:19, DaleCurtis wrote:
> Presumably all three of these methods are being called on the UI thread only?

[jam, 2014-07-23 22:32:44]

content lgtm

https://codereview.chromium.org/415433002/diff/40001/content/renderer/speech_...
File content/renderer/speech_recognition_dispatcher.cc (right):

https://codereview.chromium.org/415433002/diff/40001/content/renderer/speech_...
content/renderer/speech_recognition_dispatcher.cc:70: 
nit: here and below, don't change

[qinmin, 2014-07-23 22:35:57]

https://codereview.chromium.org/415433002/diff/40001/content/renderer/speech_...
File content/renderer/speech_recognition_dispatcher.cc (right):

https://codereview.chromium.org/415433002/diff/40001/content/renderer/speech_...
content/renderer/speech_recognition_dispatcher.cc:70: 
On 2014/07/23 22:32:44, jam wrote:
> nit: here and below, don't change

Done.

[qinmin, 2014-07-23 22:36:25]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2014-07-23 22:40:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/qinmin@chromium.org/415433002/60001

[qinmin, 2014-07-23 23:06:25]

Committed patchset #4 manually as r285072 (presubmit successful).

[no longer working on chromium, 2014-07-24 11:00:29]

Min, please look at my comment about speech_recognition_dispatcher_ in
render_view_impl.c

https://codereview.chromium.org/415433002/diff/60001/content/renderer/render_...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/415433002/diff/60001/content/renderer/render_...
content/renderer/render_view_impl.cc:3567:
speech_recognition_dispatcher_->AbortAllRecognitions();
what happen if speechRecognizer() has been called, this
speech_recognition_dispatcher_ will be NULL in such case.

https://codereview.chromium.org/415433002/diff/60001/content/renderer/speech_...
File content/renderer/speech_recognition_dispatcher.cc (right):

https://codereview.chromium.org/415433002/diff/60001/content/renderer/speech_...
content/renderer/speech_recognition_dispatcher.cc:40: iter != handle_map_.end();
fix the indentation

[johnme, 2014-07-24 12:25:53]

A revert of this CL has been created in
https://codereview.chromium.org/416053002/ by johnme@chromium.org.

The reason for reverting is: Tentatively reverting because [1] has been
consistently crashing in 2 layout tests ever since this landed[2], and this is
the more likely looking of the two CLs on the blamelist:

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=%2F...

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?u...

[1]:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Ne...

[2]:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Ne....