chrome/browser/download/download_query.h - Issue 415423002: Remove Create*Value (except CreateNullValue)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_query.h

Issue 415423002: Remove Create*Value (except CreateNullValue) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_query.h

diff --git a/chrome/browser/download/download_query.h b/chrome/browser/download/download_query.h

index 7aaf4beaedca1cd2ca5e10eafadfa37f09967bcc..0a222f030d58d034ab95bb511e46b0bb8c5232a4 100644

--- a/chrome/browser/download/download_query.h

+++ b/chrome/browser/download/download_query.h

@@ -26,8 +26,8 @@ class Value;

// id ascending.

// DownloadQuery query;

-// scoped_ptr<base::Value> start_time(base::Balue::CreateIntegerValue(0));

-// CHECK(query.AddFilter(FILTER_START_TIME, *start_time.get()));

+// base::FundamentalValue start_time(0);

+// CHECK(query.AddFilter(FILTER_START_TIME, start_time));

// bool FilterOutOddDownloads(const DownloadItem& item) {

// return 0 == (item.GetId() % 2);

// }

« no previous file with comments | « base/values.cc ('k') | chromeos/dbus/shill_ipconfig_client_unittest.cc » ('j') | no next file with comments »