Fix more stack smashing bugs in test.

Fix more stack smashing bugs in test.

R=mstarzinger@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=22821

[Michael Starzinger, 2014-08-04 14:09:58]

LGTM.

https://codereview.chromium.org/415403008/diff/1/test/cctest/compiler/test-si...
File test/cctest/compiler/test-simplified-lowering.cc (right):

https://codereview.chromium.org/415403008/diff/1/test/cctest/compiler/test-si...
test/cctest/compiler/test-simplified-lowering.cc:399: Smi* smis[] =
{Smi::FromInt(1), Smi::FromInt(2), Smi::FromInt(3),
suggestion: We could memset the array to canary values on each iteration of the
i-j-loop and at the end (after the k-loop) memcmp that all element except the
one we tested against is untouched. Not sure whether it's worth it though.

https://codereview.chromium.org/415403008/diff/1/test/cctest/compiler/test-si...
test/cctest/compiler/test-simplified-lowering.cc:417: printf("i = %ld, j =
%ld\n", i, j);
nit: Looks like a leftover.

[titzer, 2014-08-04 14:17:58]

Committed patchset #2 manually as 22821 (tree was closed).

[titzer, 2014-08-04 14:18:39]

On 2014/08/04 14:09:58, Michael Starzinger wrote:
> LGTM.
> 
>
https://codereview.chromium.org/415403008/diff/1/test/cctest/compiler/test-si...
> File test/cctest/compiler/test-simplified-lowering.cc (right):
> 
>
https://codereview.chromium.org/415403008/diff/1/test/cctest/compiler/test-si...
> test/cctest/compiler/test-simplified-lowering.cc:399: Smi* smis[] =
> {Smi::FromInt(1), Smi::FromInt(2), Smi::FromInt(3),
> suggestion: We could memset the array to canary values on each iteration of
the
> i-j-loop and at the end (after the k-loop) memcmp that all element except the
> one we tested against is untouched. Not sure whether it's worth it though.
> 

Can't trust myself today....

>
https://codereview.chromium.org/415403008/diff/1/test/cctest/compiler/test-si...
> test/cctest/compiler/test-simplified-lowering.cc:417: printf("i = %ld, j =
> %ld\n", i, j);
> nit: Looks like a leftover.

Done.