Non-SFI mode: SCONS_NONSFI_TC clean up.

Non-SFI mode: SCONS_NONSFI_TC clean up.

This CL removes SCONS_NONSFI_TC variable from buildbot_pnacl.sh,
by merging it into SCONS_NONSFI_TESTS.
So, these tests run also on bots actually.

This is relanding of r13516. The diff from the original CL was:
- test3 in mmap_test.cc is skipped in non-SFI mode intentionally.
- socket related syscalls on ARM Linux is fixed by r13527

TEST=Ran trybots
BUG=https://code.google.com/p/chromium/issues/detail?id=358465
R=mseaborn@chromium.org

Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=13542

[hidehiko, 2014-07-25 00:40:28]

Hi Mark,

Thank you for your review in advance,
- hidehiko

[Mark Seaborn, 2014-07-25 20:54:55]

LGTM

https://codereview.chromium.org/415383002/diff/1/tests/mmap/mmap_test.cc
File tests/mmap/mmap_test.cc (right):

https://codereview.chromium.org/415383002/diff/1/tests/mmap/mmap_test.cc#newc...
tests/mmap/mmap_test.cc:231: * This test is designed to made sure NaClSyscall
mmap's behavior returns
"make sure"

How about: "This test checks a security property of the NaCl TCB.  However, when
calling Linux's mmap() syscall directly, we can't necessarily expect a specific
error value for this case."

[Mark Seaborn, 2014-07-28 21:08:31]

Can you commit this, please?  It overlaps with Derek's change
(https://codereview.chromium.org/426763002/).

[hidehiko, 2014-07-28 22:11:06]

Sorry for being late. I have taken vacation on last Friday and Monday.
Submitting.

https://codereview.chromium.org/415383002/diff/1/tests/mmap/mmap_test.cc
File tests/mmap/mmap_test.cc (right):

https://codereview.chromium.org/415383002/diff/1/tests/mmap/mmap_test.cc#newc...
tests/mmap/mmap_test.cc:231: * This test is designed to made sure NaClSyscall
mmap's behavior returns
On 2014/07/25 20:54:54, Mark Seaborn wrote:
> "make sure"
> 
> How about: "This test checks a security property of the NaCl TCB.  However,
when
> calling Linux's mmap() syscall directly, we can't necessarily expect a
specific
> error value for this case."

Done.

[hidehiko, 2014-07-28 22:12:22]

Committed patchset #2 manually as r13542 (presubmit successful).