Source/web/PopupListBox.cpp - Issue 415343003: Option Groups with display: none should not show the children option elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/PopupListBox.cpp

Issue 415343003: Option Groups with display: none should not show the children option elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed assert failure in linux dbg build Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/PopupListBox.cpp

diff --git a/Source/web/PopupListBox.cpp b/Source/web/PopupListBox.cpp

index 6975b3179de6e80210ef33b6c02ea550b2b0bdcf..13e9b8d398136949bc51312a83fc9b2aa0433f83 100644

--- a/Source/web/PopupListBox.cpp

+++ b/Source/web/PopupListBox.cpp

@@ -713,6 +713,7 @@ void PopupListBox::updateFromElement()

PopupMenuStyle style = m_popupClient->itemStyle(i);

m_items[i]->textDirection = style.textDirection();

m_items[i]->hasTextDirectionOverride = style.hasTextDirectionOverride();

+ m_items[i]->displayNone = style.isDisplayNone();

}

m_selectedIndex = m_popupClient->selectedIndex();

« no previous file with comments | « Source/web/PopupListBox.h ('k') | no next file » | no next file with comments »