Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: Source/web/PopupListBox.h

Issue 415343003: Option Groups with display: none should not show the children option elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed assert failure in linux dbg build Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/web/ExternalPopupMenu.cpp ('k') | Source/web/PopupListBox.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2011, Google Inc. All rights reserved. 2 * Copyright (c) 2011, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 , type(type) 75 , type(type)
76 , yOffset(0) 76 , yOffset(0)
77 { 77 {
78 } 78 }
79 String label; 79 String label;
80 Type type; 80 Type type;
81 int yOffset; // y offset of this item, relative to the top of the popup. 81 int yOffset; // y offset of this item, relative to the top of the popup.
82 blink::TextDirection textDirection; 82 blink::TextDirection textDirection;
83 bool hasTextDirectionOverride; 83 bool hasTextDirectionOverride;
84 bool enabled; 84 bool enabled;
85 bool displayNone;
85 }; 86 };
86 87
87 // This class uses WebCore code to paint and handle events for a drop-down list 88 // This class uses WebCore code to paint and handle events for a drop-down list
88 // box ("combobox" on Windows). 89 // box ("combobox" on Windows).
89 class PopupListBox FINAL : public blink::FramelessScrollView, public PopupConten t { 90 class PopupListBox FINAL : public blink::FramelessScrollView, public PopupConten t {
90 public: 91 public:
91 static PassRefPtr<PopupListBox> create(blink::PopupMenuClient* client, bool deviceSupportsTouch) 92 static PassRefPtr<PopupListBox> create(blink::PopupMenuClient* client, bool deviceSupportsTouch)
92 { 93 {
93 return adoptRef(new PopupListBox(client, deviceSupportsTouch)); 94 return adoptRef(new PopupListBox(client, deviceSupportsTouch));
94 } 95 }
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
273 // If width exeeds screen width, we have to clip it. 274 // If width exeeds screen width, we have to clip it.
274 int m_maxWindowWidth; 275 int m_maxWindowWidth;
275 276
276 // To forward last mouse release event. 277 // To forward last mouse release event.
277 RefPtrWillBePersistent<blink::Element> m_focusedElement; 278 RefPtrWillBePersistent<blink::Element> m_focusedElement;
278 }; 279 };
279 280
280 } // namespace blink 281 } // namespace blink
281 282
282 #endif 283 #endif
OLDNEW
« no previous file with comments | « Source/web/ExternalPopupMenu.cpp ('k') | Source/web/PopupListBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698