Source/web/ExternalPopupMenu.h - Issue 415343003: Option Groups with display: none should not show the children option elements

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/web/ExternalPopupMenu.h

Issue 415343003: Option Groups with display: none should not show the children option elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed assert failure in linux dbg build Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/core/rendering/RenderMenuList.cpp ('k') | Source/web/ExternalPopupMenu.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010 Google Inc. All rights reserved.	2 * Copyright (C) 2010 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 59 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
70 // WebExternalPopupClient methods:	70 // WebExternalPopupClient methods:

71 virtual void didChangeSelection(int index) OVERRIDE;	71 virtual void didChangeSelection(int index) OVERRIDE;

72 virtual void didAcceptIndex(int index) OVERRIDE;	72 virtual void didAcceptIndex(int index) OVERRIDE;

73 virtual void didAcceptIndices(const WebVector<int>& indices) OVERRIDE;	73 virtual void didAcceptIndices(const WebVector<int>& indices) OVERRIDE;

74 virtual void didCancel() OVERRIDE;	74 virtual void didCancel() OVERRIDE;

75	75

76 void dispatchEvent(blink::Timer<ExternalPopupMenu>*);	76 void dispatchEvent(blink::Timer<ExternalPopupMenu>*);

77 // Fills \|info\| with the popup menu information contained in the	77 // Fills \|info\| with the popup menu information contained in the

78 // blink::PopupMenuClient associated with this ExternalPopupMenu.	78 // blink::PopupMenuClient associated with this ExternalPopupMenu.

79 void getPopupMenuInfo(WebPopupMenuInfo* info);	79 void getPopupMenuInfo(WebPopupMenuInfo* info);

	80 int toPopupMenuItemIndex(int index);

	81 int toExternalPopupMenuItemIndex(int index);

80	82

81 blink::PopupMenuClient* m_popupMenuClient;	83 blink::PopupMenuClient* m_popupMenuClient;

82 RefPtr<blink::FrameView> m_frameView;	84 RefPtr<blink::FrameView> m_frameView;

83 WebViewImpl& m_webView;	85 WebViewImpl& m_webView;

84 OwnPtr<WebMouseEvent> m_syntheticEvent;	86 OwnPtr<WebMouseEvent> m_syntheticEvent;

85 blink::Timer<ExternalPopupMenu> m_dispatchEventTimer;	87 blink::Timer<ExternalPopupMenu> m_dispatchEventTimer;

86 // The actual implementor of the show menu.	88 // The actual implementor of the show menu.

87 WebExternalPopupMenu* m_webExternalPopupMenu;	89 WebExternalPopupMenu* m_webExternalPopupMenu;

88 };	90 };

89	91

90 } // namespace blink	92 } // namespace blink

91	93

92 #endif // ExternalPopupMenu_h	94 #endif // ExternalPopupMenu_h

OLD	NEW