Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: Source/core/html/HTMLOptionElement.h

Issue 415343003: Option Groups with display: none should not show the children option elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed assert failure in linux dbg build Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2010, 2011 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2010, 2011 Apple Inc. All rights reserved.
6 * Copyright (C) 2010 Google Inc. All rights reserved. 6 * Copyright (C) 2010 Google Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 60
61 virtual bool isDisabledFormControl() const OVERRIDE; 61 virtual bool isDisabledFormControl() const OVERRIDE;
62 62
63 String textIndentedToRespectGroupLabel() const; 63 String textIndentedToRespectGroupLabel() const;
64 64
65 void setSelectedState(bool); 65 void setSelectedState(bool);
66 66
67 HTMLFormElement* form() const; 67 HTMLFormElement* form() const;
68 bool spatialNavigationFocused() const; 68 bool spatialNavigationFocused() const;
69 69
70 bool isDisplayNone() const;
70 private: 71 private:
71 explicit HTMLOptionElement(Document&); 72 explicit HTMLOptionElement(Document&);
72 virtual ~HTMLOptionElement(); 73 virtual ~HTMLOptionElement();
73 74
74 virtual bool rendererIsFocusable() const OVERRIDE { return true; } 75 virtual bool rendererIsFocusable() const OVERRIDE { return true; }
75 virtual void attach(const AttachContext& = AttachContext()) OVERRIDE; 76 virtual void attach(const AttachContext& = AttachContext()) OVERRIDE;
76 virtual void detach(const AttachContext& = AttachContext()) OVERRIDE; 77 virtual void detach(const AttachContext& = AttachContext()) OVERRIDE;
77 virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERR IDE; 78 virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERR IDE;
78 virtual InsertionNotificationRequest insertedInto(ContainerNode*) OVERRIDE; 79 virtual InsertionNotificationRequest insertedInto(ContainerNode*) OVERRIDE;
79 virtual void removedFrom(ContainerNode*) OVERRIDE; 80 virtual void removedFrom(ContainerNode*) OVERRIDE;
(...skipping 12 matching lines...) Expand all
92 void updateLabel(); 93 void updateLabel();
93 94
94 bool m_disabled; 95 bool m_disabled;
95 bool m_isSelected; 96 bool m_isSelected;
96 RefPtr<RenderStyle> m_style; 97 RefPtr<RenderStyle> m_style;
97 }; 98 };
98 99
99 } // namespace blink 100 } // namespace blink
100 101
101 #endif 102 #endif
OLDNEW
« no previous file with comments | « LayoutTests/fast/forms/select/popup-with-display-none-optgroup-expected.txt ('k') | Source/core/html/HTMLOptionElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698