Option Groups with display: none should not show the children option elements

Source/core/html/HTMLOptionElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2004, 2005, 2006, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2011 Motorola Mobility, Inc.  All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 268 matching lines @@
 }
 
 void HTMLOptionElement::setLabel(const AtomicString& label)
 {
     setAttribute(labelAttr, label);
 }
 
 void HTMLOptionElement::updateNonRenderStyle()
 {
     m_style = originalStyleForRenderer();
+    if (m_style->display() != NONE) {
+        HTMLElement* parent = Traversal<HTMLElement>::firstAncestor(*this);
+        ASSERT(parent);
+        if (parent->hasTagName(optgroupTag)) {
+            RenderStyle* parentStyle = parent->renderStyle() ? parent->renderStyle() : parent->computedStyle();
+            if (parentStyle && parentStyle->display() == NONE)
+                m_style->setDisplay(NONE);

[keishi, 2014/08/04 03:04:03]

I don't think we should be changing the style of the option element.

We used to have HTMLOptionElement::isDisplayNone and
HTMLOptGroupElement::isDisplayNone before r178354.
We should revive those and use them inside HTMLSelectElement::nextValidIndex and
RenderMenuList::itemStyle.

[spartha, 2014/08/04 15:59:02]

Done.

+        }
+    }
     if (HTMLSelectElement* select = ownerSelectElement())
         select->updateListOnRenderer();
 }
 
 RenderStyle* HTMLOptionElement::nonRendererStyle() const
 {
     return m_style.get();
 }
 
 PassRefPtr<RenderStyle> HTMLOptionElement::customStyleForRenderer()
@@ skipping 92 matching lines @@
 
 bool HTMLOptionElement::spatialNavigationFocused() const
 {
     HTMLSelectElement* select = ownerSelectElement();
     if (!select || !select->focused())
         return false;
     return select->spatialNavigationFocusedOption() == this;
 }
 
 } // namespace blink