Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: trunk/src/net/quic/quic_connection_logger.cc

Issue 415333005: Revert 285446 "Log the certificate subjects from the server cert..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/net/quic/quic_connection_logger.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/net/quic/quic_connection_logger.cc
===================================================================
--- trunk/src/net/quic/quic_connection_logger.cc (revision 285479)
+++ trunk/src/net/quic/quic_connection_logger.cc (working copy)
@@ -15,8 +15,6 @@
#include "base/values.h"
#include "net/base/net_log.h"
#include "net/base/net_util.h"
-#include "net/cert/cert_verify_result.h"
-#include "net/cert/x509_certificate.h"
#include "net/quic/crypto/crypto_handshake_message.h"
#include "net/quic/crypto/crypto_protocol.h"
#include "net/quic/quic_address_mismatch.h"
@@ -241,23 +239,6 @@
return dict;
}
-base::Value* NetLogQuicCertificateVerifiedCallback(
- scoped_refptr<X509Certificate> cert,
- NetLog::LogLevel /* log_level */) {
- // Only the subjects are logged so that we can investigate connection pooling.
- // More fields could be logged in the future.
- std::vector<std::string> dns_names;
- cert->GetDNSNames(&dns_names);
- base::DictionaryValue* dict = new base::DictionaryValue();
- base::ListValue* subjects = new base::ListValue();
- for (std::vector<std::string>::const_iterator it = dns_names.begin();
- it != dns_names.end(); it++) {
- subjects->Append(new base::StringValue(*it));
- }
- dict->Set("subjects", subjects);
- return dict;
-}
-
void UpdatePacketGapSentHistogram(size_t num_consecutive_missing_packets) {
UMA_HISTOGRAM_COUNTS("Net.QuicSession.PacketGapSent",
num_consecutive_missing_packets);
@@ -691,13 +672,6 @@
}
}
-void QuicConnectionLogger::OnCertificateVerified(
- const CertVerifyResult& result) {
- net_log_.AddEvent(
- NetLog::TYPE_QUIC_SESSION_CERTIFICATE_VERIFIED,
- base::Bind(&NetLogQuicCertificateVerifiedCallback, result.verified_cert));
-}
-
base::HistogramBase* QuicConnectionLogger::GetPacketSequenceNumberHistogram(
const char* statistic_name) const {
string prefix("Net.QuicSession.PacketReceived_");
« no previous file with comments | « trunk/src/net/quic/quic_connection_logger.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698