Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: extensions/browser/PRESUBMIT.py

Issue 415323002: Update masters after the tryserver split. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressing comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Chromium presubmit script for src/extensions/browser. 5 """Chromium presubmit script for src/extensions/browser.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details on the presubmit API built into gcl. 8 for more details on the presubmit API built into gcl.
9 """ 9 """
10 10
11 import sys 11 import sys
12 12
13 def GetPreferredTryMasters(project, change): 13 def GetPreferredTryMasters(project, change):
14 return { 14 return {
15 'tryserver.chromium': { 15 'tryserver.chromium.linux': {
16 'linux_chromium_chromeos_rel': set(['defaulttests']), 16 'linux_chromium_chromeos_rel': set(['defaulttests']),
17 } 17 }
18 } 18 }
19 19
20 def _CreateHistogramValueChecker(input_api, output_api): 20 def _CreateHistogramValueChecker(input_api, output_api):
21 original_sys_path = sys.path 21 original_sys_path = sys.path
22 22
23 try: 23 try:
24 sys.path.append(input_api.os_path.join( 24 sys.path.append(input_api.os_path.join(
25 input_api.PresubmitLocalPath(), '..', '..', 'tools', 25 input_api.PresubmitLocalPath(), '..', '..', 'tools',
26 'strict_enum_value_checker')) 26 'strict_enum_value_checker'))
27 from strict_enum_value_checker import StrictEnumValueChecker 27 from strict_enum_value_checker import StrictEnumValueChecker
28 finally: 28 finally:
29 sys.path = original_sys_path 29 sys.path = original_sys_path
30 30
31 return StrictEnumValueChecker(input_api, output_api, 31 return StrictEnumValueChecker(input_api, output_api,
32 start_marker='enum HistogramValue {', end_marker=' // Last entry:', 32 start_marker='enum HistogramValue {', end_marker=' // Last entry:',
33 path='extensions/browser/extension_function_histogram_value.h') 33 path='extensions/browser/extension_function_histogram_value.h')
34 34
35 def CheckChangeOnUpload(input_api, output_api): 35 def CheckChangeOnUpload(input_api, output_api):
36 results = [] 36 results = []
37 results += _CreateHistogramValueChecker(input_api, output_api).Run() 37 results += _CreateHistogramValueChecker(input_api, output_api).Run()
38 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api) 38 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)
39 return results 39 return results
40 40
41 def CheckChangeOnCommit(input_api, output_api): 41 def CheckChangeOnCommit(input_api, output_api):
42 return _CreateHistogramValueChecker(input_api, output_api).Run() 42 return _CreateHistogramValueChecker(input_api, output_api).Run()
OLDNEW
« PRESUBMIT_test.py ('K') | « crypto/PRESUBMIT.py ('k') | jingle/PRESUBMIT.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698