Update masters after the tryserver split.

Update masters after the tryserver split.

Also replace deprecated linux_chromium_rel with linux_chromium_rel_swarming, while I'm at it.

R=agable@chromium.org, maruel@chromium.org
BUG=395196
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285752

[Sergey Berezin, 2014-07-24 21:17:49]

PTAL. This should land soon after the try server is split, restarted, and the
change sticks (not reverted).

[M-A Ruel, 2014-07-24 23:38:23]

Update description to note the linux_chromium_rel_swarming change.

lgtm after fixes.

https://codereview.chromium.org/415323002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/415323002/diff/1/PRESUBMIT.py#newcode1435
PRESUBMIT.py:1435: if bot.count('gpu'):
if 'gpu' in bot:

https://codereview.chromium.org/415323002/diff/1/PRESUBMIT_test.py
File PRESUBMIT_test.py (right):

https://codereview.chromium.org/415323002/diff/1/PRESUBMIT_test.py#newcode655
PRESUBMIT_test.py:655: 'linux_chromeos_asan',
sort

https://codereview.chromium.org/415323002/diff/1/PRESUBMIT_test.py#newcode713
PRESUBMIT_test.py:713: 'win_chromium_x64_rel',
sort all, including the keys

[Sergey Berezin, 2014-07-24 23:45:43]

Thanks!

https://codereview.chromium.org/415323002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/415323002/diff/1/PRESUBMIT.py#newcode1435
PRESUBMIT.py:1435: if bot.count('gpu'):
On 2014/07/24 23:38:22, M-A Ruel wrote:
> if 'gpu' in bot:

Done.

https://codereview.chromium.org/415323002/diff/1/PRESUBMIT_test.py
File PRESUBMIT_test.py (right):

https://codereview.chromium.org/415323002/diff/1/PRESUBMIT_test.py#newcode655
PRESUBMIT_test.py:655: 'linux_chromeos_asan',
On 2014/07/24 23:38:22, M-A Ruel wrote:
> sort

Done.

https://codereview.chromium.org/415323002/diff/1/PRESUBMIT_test.py#newcode713
PRESUBMIT_test.py:713: 'win_chromium_x64_rel',
On 2014/07/24 23:38:22, M-A Ruel wrote:
> sort all, including the keys

Done.

[agable, 2014-07-24 23:58:03]

Mostly lgtm.

https://codereview.chromium.org/415323002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/415323002/diff/20001/PRESUBMIT.py#newcode1514
PRESUBMIT.py:1514: 'linux_chromium_rel_swarming': ['defaulttests'],
Why is this part of this CL? Seems like it should have a CL of its own.

https://codereview.chromium.org/415323002/diff/20001/PRESUBMIT_test.py
File PRESUBMIT_test.py (right):

https://codereview.chromium.org/415323002/diff/20001/PRESUBMIT_test.py#newcod...
PRESUBMIT_test.py:653: bots = {
I feel like this list is going to get really out of date really quickly. And
having to make a change in src/ every time someone adds or removes a bot is
non-ideal. What else can be done here?

[Sergey Berezin, 2014-07-25 00:55:46]

https://codereview.chromium.org/415323002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/415323002/diff/20001/PRESUBMIT.py#newcode1514
PRESUBMIT.py:1514: 'linux_chromium_rel_swarming': ['defaulttests'],
On 2014/07/24 23:58:02, agable wrote:
> Why is this part of this CL? Seems like it should have a CL of its own.

I think you're right. But now I'd have to spend time splitting it off. Is it
worth it?

https://codereview.chromium.org/415323002/diff/20001/PRESUBMIT_test.py
File PRESUBMIT_test.py (right):

https://codereview.chromium.org/415323002/diff/20001/PRESUBMIT_test.py#newcod...
PRESUBMIT_test.py:653: bots = {
On 2014/07/24 23:58:03, agable wrote:
> I feel like this list is going to get really out of date really quickly. And
> having to make a change in src/ every time someone adds or removes a bot is
> non-ideal. What else can be done here?

It's just a test, making sure the current bots get classified correctly. It's
probably OK for it to go stale, to some degree. And adding a bot at the moment
still requires modifying some PRESUBMITs. We'll have to solve this problem
later, and definitely not in this CL.

[Sergiy Byelozyorov, 2014-07-25 09:40:02]

Passing-by:

https://codereview.chromium.org/415323002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/415323002/diff/20001/PRESUBMIT.py#newcode1514
PRESUBMIT.py:1514: 'linux_chromium_rel_swarming': ['defaulttests'],
On 2014/07/25 00:55:45, Sergey Berezin wrote:
> On 2014/07/24 23:58:02, agable wrote:
> > Why is this part of this CL? Seems like it should have a CL of its own.
> 
> I think you're right. But now I'd have to spend time splitting it off. Is it
> worth it?
If you decide to keep it, please mention this change in the description too.

[Sergey Berezin, 2014-07-25 15:46:54]

https://codereview.chromium.org/415323002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/415323002/diff/20001/PRESUBMIT.py#newcode1514
PRESUBMIT.py:1514: 'linux_chromium_rel_swarming': ['defaulttests'],
On 2014/07/25 09:40:01, Sergiy Byelozyorov wrote:
> On 2014/07/25 00:55:45, Sergey Berezin wrote:
> > On 2014/07/24 23:58:02, agable wrote:
> > > Why is this part of this CL? Seems like it should have a CL of its own.
> > 
> > I think you're right. But now I'd have to spend time splitting it off. Is it
> > worth it?
> If you decide to keep it, please mention this change in the description too.

Done.

[Sergey Berezin, 2014-07-26 04:38:38]

Committed patchset #4 manually as r285752 (tree was closed).