Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: pkg/analysis_server/lib/src/domain_analysis.dart

Issue 415263002: Drop 'errorToJson', use server's AnalysisError. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/domain_analysis.dart
diff --git a/pkg/analysis_server/lib/src/domain_analysis.dart b/pkg/analysis_server/lib/src/domain_analysis.dart
index 3526ce97fd3b2958c51368cab9ac7064d4e89832..0b4019b4027639ced159e1135d2da1484a0987f2 100644
--- a/pkg/analysis_server/lib/src/domain_analysis.dart
+++ b/pkg/analysis_server/lib/src/domain_analysis.dart
@@ -8,13 +8,13 @@ import 'dart:collection';
import 'package:analysis_server/src/analysis_server.dart';
import 'package:analysis_server/src/computer/computer_hover.dart';
+import 'package:analysis_server/src/computer/error.dart';
import 'package:analysis_server/src/constants.dart';
-import 'package:analysis_server/src/operation/operation_analysis.dart';
import 'package:analysis_server/src/protocol.dart';
import 'package:analysis_services/constants.dart';
import 'package:analyzer/src/generated/ast.dart';
import 'package:analyzer/src/generated/engine.dart';
-import 'package:analyzer/src/generated/error.dart';
+
/**
* Instances of the class [AnalysisDomainHandler] implement a [RequestHandler]
@@ -42,9 +42,7 @@ class AnalysisDomainHandler implements RequestHandler {
if (errorInfo == null) {
response.setResult(ERRORS, []);
} else {
- response.setResult(ERRORS, errorInfo.errors.map((AnalysisError error) {
- return errorToJson(errorInfo.lineInfo, error);
- }).toList());
+ response.setResult(ERRORS, engineErrorInfoToJson(errorInfo));
}
server.sendResponse(response);
}).catchError((message) {
« no previous file with comments | « pkg/analysis_server/lib/src/computer/error.dart ('k') | pkg/analysis_server/lib/src/operation/operation_analysis.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698