Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 415243003: Drop slower Node::hasID() / Node::hasClass() methods (Closed)

Created:
6 years, 5 months ago by Inactive
Modified:
6 years, 5 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, sof, eae+blinkwatch, leviw+renderwatch, blink-reviews-dom_chromium.org, dglazkov+blink, jchaffraix+rendering, pdr., rune+blink, rwlbuis
Project:
blink
Visibility:
Public.

Description

Drop slower Node::hasID() / Node::hasClass() methods Drop slower Node::hasID() / Node::hasClass() methods. Those were here for convenience but there are very few remaining callers as we use tighter typing in the code these days. Removing them will encourage future callers to use tighter typing and call the methods on Element. This CL updates the 2 remaining call sites to use the methods on Element instead. R=abarth@chromium.org, eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178885

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -33 lines) Patch
M Source/core/dom/Element.h View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/dom/Node.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +16 lines, -13 lines 0 comments Download
M Source/core/rendering/RenderTreeAsText.cpp View 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 5 months ago (2014-07-24 21:11:36 UTC) #1
eseidel
lgtm
6 years, 5 months ago (2014-07-25 00:29:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/415243003/1
6 years, 5 months ago (2014-07-25 00:30:16 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 00:34:50 UTC) #4
Message was sent while issue was closed.
Change committed as 178885

Powered by Google App Engine
This is Rietveld 408576698