Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 415203003: Delay unregistering handlers when a document is detached (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/page/Page.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 #include "core/editing/SpellChecker.h" 103 #include "core/editing/SpellChecker.h"
104 #include "core/editing/markup.h" 104 #include "core/editing/markup.h"
105 #include "core/events/BeforeUnloadEvent.h" 105 #include "core/events/BeforeUnloadEvent.h"
106 #include "core/events/Event.h" 106 #include "core/events/Event.h"
107 #include "core/events/EventFactory.h" 107 #include "core/events/EventFactory.h"
108 #include "core/events/EventListener.h" 108 #include "core/events/EventListener.h"
109 #include "core/events/HashChangeEvent.h" 109 #include "core/events/HashChangeEvent.h"
110 #include "core/events/PageTransitionEvent.h" 110 #include "core/events/PageTransitionEvent.h"
111 #include "core/events/ScopedEventQueue.h" 111 #include "core/events/ScopedEventQueue.h"
112 #include "core/fetch/ResourceFetcher.h" 112 #include "core/fetch/ResourceFetcher.h"
113 #include "core/frame/EventHandlerRegistry.h"
113 #include "core/frame/LocalDOMWindow.h" 114 #include "core/frame/LocalDOMWindow.h"
114 #include "core/frame/FrameConsole.h" 115 #include "core/frame/FrameConsole.h"
115 #include "core/frame/FrameHost.h" 116 #include "core/frame/FrameHost.h"
116 #include "core/frame/FrameView.h" 117 #include "core/frame/FrameView.h"
117 #include "core/frame/History.h" 118 #include "core/frame/History.h"
118 #include "core/frame/LocalFrame.h" 119 #include "core/frame/LocalFrame.h"
119 #include "core/frame/Settings.h" 120 #include "core/frame/Settings.h"
120 #include "core/frame/csp/ContentSecurityPolicy.h" 121 #include "core/frame/csp/ContentSecurityPolicy.h"
121 #include "core/html/DocumentNameCollection.h" 122 #include "core/html/DocumentNameCollection.h"
122 #include "core/html/HTMLAllCollection.h" 123 #include "core/html/HTMLAllCollection.h"
(...skipping 2074 matching lines...) Expand 10 before | Expand all | Expand 10 after
2197 m_activeHoverElement = nullptr; 2198 m_activeHoverElement = nullptr;
2198 m_autofocusElement = nullptr; 2199 m_autofocusElement = nullptr;
2199 2200
2200 m_renderView = 0; 2201 m_renderView = 0;
2201 ContainerNode::detach(context); 2202 ContainerNode::detach(context);
2202 2203
2203 m_styleEngine->didDetach(); 2204 m_styleEngine->didDetach();
2204 2205
2205 if (Document* parentDoc = parentDocument()) 2206 if (Document* parentDoc = parentDocument())
2206 parentDoc->didClearTouchEventHandlers(this); 2207 parentDoc->didClearTouchEventHandlers(this);
2208 frameHost()->eventHandlerRegistry().documentDetached(*this);
2207 2209
2208 // This is required, as our LocalFrame might delete itself as soon as it det aches 2210 // This is required, as our LocalFrame might delete itself as soon as it det aches
2209 // us. However, this violates Node::detach() semantics, as it's never 2211 // us. However, this violates Node::detach() semantics, as it's never
2210 // possible to re-attach. Eventually Document::detach() should be renamed, 2212 // possible to re-attach. Eventually Document::detach() should be renamed,
2211 // or this setting of the frame to 0 could be made explicit in each of the 2213 // or this setting of the frame to 0 could be made explicit in each of the
2212 // callers of Document::detach(). 2214 // callers of Document::detach().
2213 m_frame = 0; 2215 m_frame = 0;
2214 2216
2215 if (m_mediaQueryMatcher) 2217 if (m_mediaQueryMatcher)
2216 m_mediaQueryMatcher->documentDetached(); 2218 m_mediaQueryMatcher->documentDetached();
(...skipping 3670 matching lines...) Expand 10 before | Expand all | Expand 10 after
5887 using namespace blink; 5889 using namespace blink;
5888 void showLiveDocumentInstances() 5890 void showLiveDocumentInstances()
5889 { 5891 {
5890 WeakDocumentSet& set = liveDocumentSet(); 5892 WeakDocumentSet& set = liveDocumentSet();
5891 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 5893 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
5892 for (WeakDocumentSet::const_iterator it = set.begin(); it != set.end(); ++it ) { 5894 for (WeakDocumentSet::const_iterator it = set.begin(); it != set.end(); ++it ) {
5893 fprintf(stderr, "- Document %p URL: %s\n", *it, (*it)->url().string().ut f8().data()); 5895 fprintf(stderr, "- Document %p URL: %s\n", *it, (*it)->url().string().ut f8().data());
5894 } 5896 }
5895 } 5897 }
5896 #endif 5898 #endif
OLDNEW
« no previous file with comments | « no previous file | Source/core/page/Page.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698