Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 415143004: Get rid of ViewManagerTransactions & pending queue. (Closed)

Created:
6 years, 5 months ago by Ben Goodger (Google)
Modified:
6 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Get rid of ViewManagerTransactions & pending queue. R=sky@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285351

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -494 lines) Patch
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h View 3 chunks +11 lines, -17 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc View 7 chunks +73 lines, -473 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
6 years, 5 months ago (2014-07-24 19:45:49 UTC) #1
sky
LGTM
6 years, 5 months ago (2014-07-24 19:47:40 UTC) #2
Ben Goodger (Google)
6 years, 5 months ago (2014-07-24 19:54:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r285351 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698