Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 415123002: Let canvas decide how to handle the lost resource: WebGL part (Closed)

Created:
6 years, 5 months ago by Hongbo Min
Modified:
6 years, 4 months ago
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

If the client code reports the resource is lost, the mailbox should be removed and also release the reference to DrawingBuffer, so that make sure the DrawingBuffer has a chance to be destroyed. BUG=390960 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179089

Patch Set 1 #

Total comments: 2

Patch Set 2 : rename test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -6 lines) Patch
M Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M Source/platform/graphics/gpu/DrawingBufferTest.cpp View 1 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Hongbo Min
kbr@, this CL is for WebGL canvas to handle the case when the resource is ...
6 years, 5 months ago (2014-07-24 14:56:55 UTC) #1
dshwang
non-owner lgtm
6 years, 4 months ago (2014-07-28 06:56:57 UTC) #2
Ken Russell (switch to Gerrit)
LGTM https://codereview.chromium.org/415123002/diff/1/Source/platform/graphics/gpu/DrawingBufferTest.cpp File Source/platform/graphics/gpu/DrawingBufferTest.cpp (right): https://codereview.chromium.org/415123002/diff/1/Source/platform/graphics/gpu/DrawingBufferTest.cpp#newcode318 Source/platform/graphics/gpu/DrawingBufferTest.cpp:318: TEST_F(DrawingBufferTest, verifyClearDrawingBufferIfResourceLost) This test looks pretty good, but ...
6 years, 4 months ago (2014-07-28 21:25:13 UTC) #3
Hongbo Min
https://codereview.chromium.org/415123002/diff/1/Source/platform/graphics/gpu/DrawingBufferTest.cpp File Source/platform/graphics/gpu/DrawingBufferTest.cpp (right): https://codereview.chromium.org/415123002/diff/1/Source/platform/graphics/gpu/DrawingBufferTest.cpp#newcode318 Source/platform/graphics/gpu/DrawingBufferTest.cpp:318: TEST_F(DrawingBufferTest, verifyClearDrawingBufferIfResourceLost) On 2014/07/28 21:25:13, Ken Russell wrote: > ...
6 years, 4 months ago (2014-07-29 00:46:47 UTC) #4
Hongbo Min
https://codereview.chromium.org/415123002/diff/1/Source/platform/graphics/gpu/DrawingBufferTest.cpp File Source/platform/graphics/gpu/DrawingBufferTest.cpp (right): https://codereview.chromium.org/415123002/diff/1/Source/platform/graphics/gpu/DrawingBufferTest.cpp#newcode318 Source/platform/graphics/gpu/DrawingBufferTest.cpp:318: TEST_F(DrawingBufferTest, verifyClearDrawingBufferIfResourceLost) On 2014/07/28 21:25:13, Ken Russell wrote: > ...
6 years, 4 months ago (2014-07-29 00:46:49 UTC) #5
Hongbo Min
The CQ bit was checked by hongbo.min@intel.com
6 years, 4 months ago (2014-07-29 00:47:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hongbo.min@intel.com/415123002/20001
6 years, 4 months ago (2014-07-29 00:48:14 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 02:38:14 UTC) #8
Message was sent while issue was closed.
Change committed as 179089

Powered by Google App Engine
This is Rietveld 408576698