Issue 4151012: Prevent needless vertical margin change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4151012: Prevent needless vertical margin change. (Closed)

Created:
10 years, 1 month ago by altimofeev

Modified:
9 years, 7 months ago

Reviewers:
sky, varunjain

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/browser/chromeos/login

Visibility:
Public.

Description

Prevent needless vertical margin change. When one change horizontal margin, vertical margin is also changed to zero. BUG=chromium-os:8081 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64550

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	views/controls/textfield/native_textfield_gtk.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

varunjain

On 2010/10/29 14:58:06, sky wrote: > LGTM Hi.. this change is causing some issues with ...

10 years, 1 month ago (2010-11-02 19:39:13 UTC) #3

altimofeev

10 years, 1 month ago (2010-11-03 07:02:37 UTC) #4

On Tue, Nov 2, 2010 at 10:39 PM, <varunjain@chromium.org> wrote:

> On 2010/10/29 14:58:06, sky wrote:
>
>> LGTM
>>
>
> Hi.. this change is causing some issues with displaying the textfield in
> the
> Find Bar (the size of the textfield inside the bar is off). It seems to be
> this
> change because the textfield looks fine if I revert it. Please check and if
> required revert or fix this.

Yes, it is. I already have fix for it:
http://codereview.chromium.org/4246002/show.

Expand Messages | Collapse Messages