Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: Source/platform/heap/ThreadState.h

Issue 415083002: [oilpan]: fix deadlock when leaving a safepoint and sweeping. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/heap/ThreadState.h
diff --git a/Source/platform/heap/ThreadState.h b/Source/platform/heap/ThreadState.h
index 1aa6c22a49eed2bb935fcbb51d62600867150590..0d65220325252008be6a1771f4421be97ad8e4c6 100644
--- a/Source/platform/heap/ThreadState.h
+++ b/Source/platform/heap/ThreadState.h
@@ -618,7 +618,7 @@ public:
class SafePointAwareMutexLocker {
WTF_MAKE_NONCOPYABLE(SafePointAwareMutexLocker);
public:
- explicit SafePointAwareMutexLocker(Mutex& mutex, ThreadState::StackState stackState = ThreadState::HeapPointersOnStack)
+ explicit SafePointAwareMutexLocker(WTF::MutexBase& mutex, ThreadState::StackState stackState = ThreadState::HeapPointersOnStack)
tkent 2014/07/25 05:11:44 We should omit WTF::
wibling-chromium 2014/07/25 09:31:28 Done.
: m_mutex(mutex)
, m_locked(false)
{
@@ -661,7 +661,7 @@ private:
m_locked = false;
}
- Mutex& m_mutex;
+ WTF::MutexBase& m_mutex;
tkent 2014/07/25 05:11:44 Ditto.
wibling-chromium 2014/07/25 09:31:28 Done.
bool m_locked;
};

Powered by Google App Engine
This is Rietveld 408576698