chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm - Issue 415053002: Remove AutocompleteMatch::is_starred

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm

Issue 415053002: Remove AutocompleteMatch::is_starred (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm

index 862a375db9b61fd56d58cdaccebb207ec1e80851..5a0951a7e1d5fe35db6fff1b6b58653a78ba434d 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm

@@ -324,7 +324,7 @@ NSImage* OmniboxPopupViewMac::ImageForMatch(const AutocompleteMatch& match) {

if (!image.IsEmpty())

return image.AsNSImage();

- const int resource_id = match.starred ?

+ const int resource_id = model_->IsStarredMatch(match) ?

IDR_OMNIBOX_STAR : AutocompleteMatch::TypeToIcon(match.type);

return OmniboxViewMac::ImageForResource(resource_id);

}