Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: chrome/browser/android/omnibox/autocomplete_controller_android.cc

Issue 415053002: Remove AutocompleteMatch::is_starred (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/autocomplete/autocomplete_match.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/omnibox/autocomplete_controller_android.cc
diff --git a/chrome/browser/android/omnibox/autocomplete_controller_android.cc b/chrome/browser/android/omnibox/autocomplete_controller_android.cc
index efb29ba2f9b5a53377bbb4b00a91b00cc4c92f4b..91015a7e33d62cb26c643eaabbef671b3a240e9c 100644
--- a/chrome/browser/android/omnibox/autocomplete_controller_android.cc
+++ b/chrome/browser/android/omnibox/autocomplete_controller_android.cc
@@ -18,6 +18,7 @@
#include "chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.h"
#include "chrome/browser/autocomplete/search_provider.h"
#include "chrome/browser/autocomplete/shortcuts_backend_factory.h"
+#include "chrome/browser/bookmarks/bookmark_model_factory.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/omnibox/omnibox_field_trial.h"
@@ -35,6 +36,7 @@
#include "chrome/common/url_constants.h"
#include "components/autocomplete/autocomplete_input.h"
#include "components/autocomplete/autocomplete_match_type.h"
+#include "components/bookmarks/browser/bookmark_model.h"
#include "components/keyed_service/content/browser_context_dependency_manager.h"
#include "components/metrics/proto/omnibox_event.pb.h"
#include "components/search/search.h"
@@ -448,6 +450,7 @@ AutocompleteControllerAndroid::BuildOmniboxSuggestion(
// Note that we are also removing 'www' host from formatted url.
ScopedJavaLocalRef<jstring> formatted_url = ConvertUTF16ToJavaString(env,
FormatURLUsingAcceptLanguages(match.stripped_destination_url));
+ BookmarkModel* bookmark_model = BookmarkModelFactory::GetForProfile(profile_);
return Java_AutocompleteController_buildOmniboxSuggestion(
env,
match.type,
@@ -460,7 +463,7 @@ AutocompleteControllerAndroid::BuildOmniboxSuggestion(
fill_into_edit.obj(),
destination_url.obj(),
formatted_url.obj(),
- match.starred,
+ bookmark_model && bookmark_model->IsBookmarked(match.destination_url),
match.SupportsDeletion());
}
« no previous file with comments | « no previous file | chrome/browser/autocomplete/autocomplete_match.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698