chrome/browser/ui/views/omnibox/omnibox_result_view.cc - Issue 415053002: Remove AutocompleteMatch::is_starred

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_result_view.cc

Issue 415053002: Remove AutocompleteMatch::is_starred (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/omnibox/omnibox_result_view.cc

diff --git a/chrome/browser/ui/views/omnibox/omnibox_result_view.cc b/chrome/browser/ui/views/omnibox/omnibox_result_view.cc

index 555f88b641f0c04426fd42d3d4b78847b5c3f09a..15782771bdfbc3c0b4b252193f51b09447412e87 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_result_view.cc

+++ b/chrome/browser/ui/views/omnibox/omnibox_result_view.cc

@@ -428,7 +428,7 @@ gfx::ImageSkia OmniboxResultView::GetIcon() const {

if (!image.IsEmpty())

return image.AsImageSkia();

- int icon = match_.starred ?

+ int icon = model_->IsStarredMatch(match_) ?

IDR_OMNIBOX_STAR : AutocompleteMatch::TypeToIcon(match_.type);

if (GetState() == SELECTED) {

switch (icon) {