Remove AutocompleteMatch::is_starred

chrome/browser/resources/omnibox/omnibox.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Javascript for omnibox.html, served from chrome://omnibox/
  * This is used to debug omnibox ranking.  The user enters some text
  * into a box, submits it, and then sees lots of debug information
  * from the autocompleter that shows what omnibox would do with that
  * input.
@@ skipping 108 matching lines @@
         'The type of the result.'),
     new PresentationInfoRecord('Relevance', '', 'relevance', true,
         'The result score. Higher is more relevant.'),
     new PresentationInfoRecord('Contents', '', 'contents', true,
         'The text that is presented identifying the result.'),
     new PresentationInfoRecord(
         'Can Be Default', '', 'allowed_to_be_default_match', false,
         'A green checkmark indicates that the result can be the default ' +
         'match (i.e., can be the match that pressing enter in the omnibox ' +
         'navigates to).'),
-    new PresentationInfoRecord('Starred', '', 'starred', false,
-        'A green checkmark indicates that the result has been bookmarked.'),

[Peter Kasting, 2014/07/24 18:51:34]

This is still useful information to know.  I think we should leave this here,
and instead of passing down match.is_starred, we should compute the starred
state of all the matches and pass that down.

[hashimoto, 2014/07/25 08:36:12]

Added code to fill |starred| in OmniboxUIHandler.

     new PresentationInfoRecord(
         'HWYT', '', 'is_history_what_you_typed_match', false,
         'A green checkmark indicates that the result is an History What You ' +
         'Typed Match'),
     new PresentationInfoRecord('Description', '', 'description', false,
         'The page title of the result.'),
     new PresentationInfoRecord('URL', '', 'destination_url', true,
         'The URL for the result.'),
     new PresentationInfoRecord('Fill Into Edit', '', 'fill_into_edit', false,
         'The text shown in the omnibox when the result is selected.'),
@@ skipping 288 matching lines @@
   OmniboxPageImpl.prototype.handleNewAutocompleteResult = function(result) {
     progressiveAutocompleteResults.push(result);
     refresh();
   };
 
   return function(handle) {
     connection = new connector.Connection(handle, OmniboxPageImpl,
                                           browser.OmniboxUIHandlerMojoProxy);
   };
 });