Remove AutocompleteMatch::is_starred

chrome/browser/autocomplete/search_provider.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/search_provider.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/base64.h"
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/i18n/break_iterator.h"
 #include "base/i18n/case_conversion.h"
 #include "base/json/json_string_value_serializer.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
 #include "base/rand_util.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/autocomplete/autocomplete_classifier.h"
 #include "chrome/browser/autocomplete/autocomplete_classifier_factory.h"
 #include "chrome/browser/autocomplete/autocomplete_provider_listener.h"
 #include "chrome/browser/autocomplete/autocomplete_result.h"
 #include "chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.h"
 #include "chrome/browser/autocomplete/keyword_provider.h"
-#include "chrome/browser/bookmarks/bookmark_model_factory.h"
 #include "chrome/browser/history/history_service.h"
 #include "chrome/browser/history/history_service_factory.h"
 #include "chrome/browser/omnibox/omnibox_field_trial.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/search_engines/template_url_service_factory.h"
 #include "chrome/browser/ui/search/instant_controller.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "components/autocomplete/url_prefix.h"
 #include "components/google/core/browser/google_util.h"
@@ skipping 374 matching lines @@
   if ((keyword_url != NULL) && HasKeywordDefaultMatchInKeywordMode()) {
     // If there is a keyword match that is allowed to be the default match,
     // then prohibit default provider matches from being the default match lest
     // such matches cause the user to break out of keyword mode.
     for (ACMatches::iterator it = matches_.begin(); it != matches_.end();
          ++it) {
       if (it->keyword != keyword_url->keyword())
         it->allowed_to_be_default_match = false;
     }
   }
-
-  base::TimeTicks update_starred_start_time(base::TimeTicks::Now());
-  UpdateStarredStateOfMatches(BookmarkModelFactory::GetForProfile(profile_));
-  UMA_HISTOGRAM_TIMES("Omnibox.SearchProvider.UpdateStarredTime",

[Peter Kasting, 2014/07/24 18:51:34]

Make sure this historgram gets properly marked as deprecated in any XML files
which refer to it.  Ping mpearson if you're not sure where to look.

[hashimoto, 2014/07/25 08:36:12]

There is no line in histograms.xml which corresponds to this histogram.
According to the original change which added this line, this histogram is
intended to appear only on about:histograms locally.
(https://codereview.chromium.org/23469012#msg14)

-                      base::TimeTicks::Now() - update_starred_start_time);
   UpdateDone();
 }
 
 void SearchProvider::Run() {
   // Start a new request with the current input.
   suggest_results_pending_ = 0;
   time_suggest_request_sent_ = base::TimeTicks::Now();
 
   default_fetcher_.reset(CreateSuggestFetcher(kDefaultProviderURLFetcherID,
       providers_.GetDefaultProviderURL(), input_));
@@ skipping 743 matching lines @@
     // Make the base64 encoded value URL and filename safe(see RFC 3548).
     std::replace(current_token_.begin(), current_token_.end(), '+', '-');
     std::replace(current_token_.begin(), current_token_.end(), '/', '_');
   }
 
   // Extend expiration time another 60 seconds.
   token_expiration_time_ = current_time + base::TimeDelta::FromSeconds(60);
 
   return current_token_;
 }