Issue 415043005: Fix flake in WindowTest.TouchCaptureCancelsOtherTouches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 415043005: Fix flake in WindowTest.TouchCaptureCancelsOtherTouches. (Closed)

Created:
6 years, 5 months ago by tdresser

Modified:
6 years, 5 months ago

Reviewers:
sadrul

CC:
chromium-reviews, sadrul, timurrrr+watch_chromium.org, kalyank, ben+aura_chromium.org, glider+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Fix flake in WindowTest.TouchCaptureCancelsOtherTouches. Previously we were using real time for event timestamps. Switch to using fake timestamps. BUG=396387 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285685

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -15 lines)			Patch
D	tools/valgrind/gtest_exclude/aura_unittests.gtest-drmemory_win32.txt	View		1 chunk	+0 lines, -2 lines	0 comments	Download
D	tools/valgrind/gtest_exclude/aura_unittests.gtest-memcheck.txt	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	ui/aura/window_unittest.cc	View	1	3 chunks	+10 lines, -11 lines	0 comments	Download

Total messages: 5 (0 generated)

tdresser

Sadrul, can you take a look? This just fixes timestamps.

6 years, 5 months ago (2014-07-25 13:33:15 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/415043005/40001

6 years, 5 months ago (2014-07-25 20:42:57 UTC) #4

Message was sent while issue was closed.

Change committed as 285685