Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 415033003: A few additional fixes for infra refactoring in testing_support (Closed)

Created:
6 years, 5 months ago by iannucci
Modified:
6 years, 5 months ago
Reviewers:
Vadim Sh., agable
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/testing/testing_support.git@master
Visibility:
Public.

Description

A few additional fixes for infra refactoring in testing_support R=agable@chromium.org, vadimsh@chromium.org BUG= Committed: https://chromium.googlesource.com/infra/testing/testing_support/+/38d3181

Patch Set 1 #

Patch Set 2 : +4 on setup indentation #

Patch Set 3 : Fix imports and setup.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
M setup.py View 1 2 2 chunks +9 lines, -12 lines 0 comments Download
M testing_support/__init__.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M testing_support/git/__init__.py View 1 chunk +5 lines, -0 lines 0 comments Download
M testing_support/git/repo.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
iannucci
never sent this :( PTAL
6 years, 5 months ago (2014-07-25 03:23:57 UTC) #1
agable
lgtm
6 years, 5 months ago (2014-07-25 17:55:33 UTC) #2
iannucci
6 years, 5 months ago (2014-07-25 20:59:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r38d3181 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698