Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 415013002: Don't use WorkerResourceProvider if --disable-embedded-shared-worker is not set. (Closed)

Created:
6 years, 5 months ago by horo
Modified:
6 years, 5 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't use WorkerResourceProvider if --disable-embedded-shared-worker is not set. BUG=364243, 396970 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285424

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/task_manager/task_manager.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
horo
nick@ Could you please review this?
6 years, 5 months ago (2014-07-24 03:16:30 UTC) #1
ncarter (slow)
lgtm
6 years, 5 months ago (2014-07-24 18:20:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/415013002/1
6 years, 5 months ago (2014-07-24 18:22:03 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 19:28:16 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 20:02:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_swarming/builds/1993)
6 years, 5 months ago (2014-07-24 20:02:15 UTC) #6
horo
The CQ bit was checked by horo@chromium.org
6 years, 5 months ago (2014-07-24 23:31:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/415013002/1
6 years, 5 months ago (2014-07-24 23:32:56 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 00:06:39 UTC) #9
Message was sent while issue was closed.
Change committed as 285424

Powered by Google App Engine
This is Rietveld 408576698