[NaCl SDK] nacl_io: Remove duplication between passthroughfs and devfs.

[NaCl SDK] nacl_io: Remove duplication between passthroughfs and devfs.

They both had implementations of RealNode.

Also update examples/tutorial/testing so that it shuts down
the NaCl module correctly.

TEST=trybots
R=binji@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285382

[Sam Clegg, 2014-07-23 23:06:58]

Maybe the new class should be called passthrough_fs_node.h?   I don't have
strong feelings either way.

[binji, 2014-07-23 23:18:09]

lgtm, thanks

https://codereview.chromium.org/414993002/diff/1/native_client_sdk/src/librar...
File native_client_sdk/src/libraries/nacl_io/kernel_wrap_newlib.cc (right):

https://codereview.chromium.org/414993002/diff/1/native_client_sdk/src/librar...
native_client_sdk/src/libraries/nacl_io/kernel_wrap_newlib.cc:265:
__libnacl_irt_dev_fdio_init();
unrelated change? If not, please mention it in the CL description.

https://codereview.chromium.org/414993002/diff/1/native_client_sdk/src/librar...
native_client_sdk/src/libraries/nacl_io/kernel_wrap_newlib.cc:295: // withing
chrome).
sp: within

https://codereview.chromium.org/414993002/diff/1/native_client_sdk/src/librar...
File native_client_sdk/src/libraries/nacl_io/passthroughfs/real_node.h (right):

https://codereview.chromium.org/414993002/diff/1/native_client_sdk/src/librar...
native_client_sdk/src/libraries/nacl_io/passthroughfs/real_node.h:14: explicit
RealNode(Filesystem* filesystem, int real_fd)
remove explicit

https://codereview.chromium.org/414993002/diff/1/native_client_sdk/src/librar...
native_client_sdk/src/libraries/nacl_io/passthroughfs/real_node.h:15: :
Node(filesystem), real_fd_(real_fd) {}
style is to not inline functions except accessors.

https://codereview.chromium.org/414993002/diff/1/native_client_sdk/src/librar...
native_client_sdk/src/libraries/nacl_io/passthroughfs/real_node.h:18: virtual
Error Init(int flags) { return 0; }
same here

https://codereview.chromium.org/414993002/diff/1/native_client_sdk/src/librar...
native_client_sdk/src/libraries/nacl_io/passthroughfs/real_node.h:47: friend
class PassthroughFs;
looks like this isn't needed.

[binji, 2014-07-23 23:18:45]

On 2014/07/23 23:06:58, Sam Clegg wrote:
> Maybe the new class should be called passthrough_fs_node.h?   I don't have
> strong feelings either way.

I think this is fine.

[Sam Clegg, 2014-07-24 21:43:43]

Committed patchset #2 manually as r285382 (presubmit successful).