Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: sync/test/fake_server/unique_client_entity.h

Issue 414953002: Make client tag IDs consistent in sync fake server (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add comment Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/test/fake_server/fake_server_entity.cc ('k') | sync/test/fake_server/unique_client_entity.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/test/fake_server/unique_client_entity.h
diff --git a/sync/test/fake_server/unique_client_entity.h b/sync/test/fake_server/unique_client_entity.h
index fecf0440412bed680ef4033224798013a0c3fae6..56fa46561e8b445d21365e5a4edf5285314a62b0 100644
--- a/sync/test/fake_server/unique_client_entity.h
+++ b/sync/test/fake_server/unique_client_entity.h
@@ -19,14 +19,12 @@ class UniqueClientEntity : public FakeServerEntity {
public:
virtual ~UniqueClientEntity();
- // Factory function for UniqueClientEntity.
- static FakeServerEntity* CreateNew(const sync_pb::SyncEntity& client_entity);
-
- // Factory function for creating a new version of an existing
- // UniqueClientEntity.
- static FakeServerEntity* CreateUpdatedVersion(
- const sync_pb::SyncEntity& client_entity,
- FakeServerEntity* current_server_entity);
+ // Factory function for creating a UniqueClientEntity.
+ static FakeServerEntity* Create(const sync_pb::SyncEntity& client_entity);
+
+ // Derives an ID from a unique client tagged entity.
+ static std::string EffectiveIdForClientTaggedEntity(
+ const sync_pb::SyncEntity& entity);
// FakeServerEntity implementation.
virtual std::string GetParentId() const OVERRIDE;
« no previous file with comments | « sync/test/fake_server/fake_server_entity.cc ('k') | sync/test/fake_server/unique_client_entity.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698