Introduce 'grab_inputs' property for athena container.

Introduce 'grab_inputs' property for athena container.

BUG=395655
R=oshima@chromium.org
TEST=athena_unittests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285371

[oshima, 2014-07-23 23:24:35]

https://codereview.chromium.org/414903002/diff/1/athena/screen/screen_manager...
File athena/screen/screen_manager_impl.cc (right):

https://codereview.chromium.org/414903002/diff/1/athena/screen/screen_manager...
athena/screen/screen_manager_impl.cc:141: return
container_->Contains(static_cast<aura::Window*>(target)) ?
We need to allow a container that has higher z-order so that virtual keyboard
still work on lock screen.

https://codereview.chromium.org/414903002/diff/1/athena/screen/screen_manager...
athena/screen/screen_manager_impl.cc:226: // and implement it.
Can you add check to make sure no other containers have this parameter set for
the time being?

[oshima, 2014-07-23 23:33:10]

and fyi: https://codereview.chromium.org/411543006/

[Jun Mukai, 2014-07-24 17:52:02]

https://codereview.chromium.org/414903002/diff/1/athena/screen/screen_manager...
File athena/screen/screen_manager_impl.cc (right):

https://codereview.chromium.org/414903002/diff/1/athena/screen/screen_manager...
athena/screen/screen_manager_impl.cc:141: return
container_->Contains(static_cast<aura::Window*>(target)) ?
On 2014/07/23 23:24:35, oshima wrote:
> We need to allow a container that has higher z-order so that virtual keyboard
> still work on lock screen.

Done.  Also added some tests.

https://codereview.chromium.org/414903002/diff/1/athena/screen/screen_manager...
athena/screen/screen_manager_impl.cc:226: // and implement it.
On 2014/07/23 23:24:35, oshima wrote:
> Can you add check to make sure no other containers have this parameter set for
> the time being?

Done.

[oshima, 2014-07-24 18:12:49]

lgtm with nits

https://codereview.chromium.org/414903002/diff/20001/athena/screen/screen_man...
File athena/screen/screen_manager_impl.cc (right):

https://codereview.chromium.org/414903002/diff/20001/athena/screen/screen_man...
athena/screen/screen_manager_impl.cc:33: bool DoesGrabInput(aura::Window*
container) {
Or GrabsInput (whichever you like).

https://codereview.chromium.org/414903002/diff/20001/athena/screen/screen_man...
athena/screen/screen_manager_impl.cc:62: }
I wonder if we need to allow a window in higher z-order to be activated.

https://codereview.chromium.org/414903002/diff/20001/athena/screen/screen_man...
athena/screen/screen_manager_impl.cc:131: AthenaEventTargeter(aura::Window*
container)
nit: explicit

https://codereview.chromium.org/414903002/diff/20001/athena/screen/screen_man...
athena/screen/screen_manager_impl.cc:293: == children.end());
add message << "input has already been grabbed by another container".

https://codereview.chromium.org/414903002/diff/20001/athena/screen/screen_man...
File athena/screen/screen_manager_unittest.cc (right):

https://codereview.chromium.org/414903002/diff/20001/athena/screen/screen_man...
athena/screen/screen_manager_unittest.cc:60:
ScreenManager::ContainerParams("test", CP_DEBUG));
can you define your own priorities ?

[Jun Mukai, 2014-07-24 18:57:26]

https://codereview.chromium.org/414903002/diff/20001/athena/screen/screen_man...
File athena/screen/screen_manager_impl.cc (right):

https://codereview.chromium.org/414903002/diff/20001/athena/screen/screen_man...
athena/screen/screen_manager_impl.cc:33: bool DoesGrabInput(aura::Window*
container) {
On 2014/07/24 18:12:48, oshima wrote:
> Or GrabsInput (whichever you like).

Done.

https://codereview.chromium.org/414903002/diff/20001/athena/screen/screen_man...
athena/screen/screen_manager_impl.cc:62: }
On 2014/07/24 18:12:48, oshima wrote:
> I wonder if we need to allow a window in higher z-order to be activated.

Done.

https://codereview.chromium.org/414903002/diff/20001/athena/screen/screen_man...
athena/screen/screen_manager_impl.cc:131: AthenaEventTargeter(aura::Window*
container)
On 2014/07/24 18:12:48, oshima wrote:
> nit: explicit

Done.

https://codereview.chromium.org/414903002/diff/20001/athena/screen/screen_man...
athena/screen/screen_manager_impl.cc:293: == children.end());
On 2014/07/24 18:12:48, oshima wrote:
> add message << "input has already been grabbed by another container".

Done.

https://codereview.chromium.org/414903002/diff/20001/athena/screen/screen_man...
File athena/screen/screen_manager_unittest.cc (right):

https://codereview.chromium.org/414903002/diff/20001/athena/screen/screen_man...
athena/screen/screen_manager_unittest.cc:60:
ScreenManager::ContainerParams("test", CP_DEBUG));
On 2014/07/24 18:12:48, oshima wrote:
> can you define your own priorities ? 

Done.

[Jun Mukai, 2014-07-24 18:59:11]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-07-24 19:01:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/414903002/40001

[commit-bot: I haz the power, 2014-07-24 21:02:14]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)

[commit-bot: I haz the power, 2014-07-24 21:09:13]

Change committed as 285371