Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: tools/bisect-perf-regression_test.py

Issue 414893002: Check for chromium revision instead of dependency module revision. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/bisect-perf-regression.py ('K') | « tools/bisect-perf-regression.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bisect-perf-regression_test.py
diff --git a/tools/bisect-perf-regression_test.py b/tools/bisect-perf-regression_test.py
index fac3a83cc6a4d0af604632768c9748b28f837084..0d232af4b40b06a075a52059a45ee605bd1f1253 100644
--- a/tools/bisect-perf-regression_test.py
+++ b/tools/bisect-perf-regression_test.py
@@ -247,6 +247,7 @@ vars = {
bisect_instance = bisect_perf_module.BisectPerformanceMetrics(
source_control, bisect_options)
bisect_instance.opts.target_platform = 'android'
+ depot = 'chromium'
# android-chrome-shell -> android-chromium-testshell
revision = 274857
git_revision = bisect_instance.source_control.ResolveToRevision(
@@ -256,7 +257,7 @@ vars = {
expected_command = ('tools/perf/run_benchmark -v --browser='
'android-chromium-testshell page_cycler.intl_ja_zh')
self.assertEqual(
- bisect_instance.GetCompatibleCommand(command, git_revision),
+ bisect_instance.GetCompatibleCommand(command, git_revision, depot),
expected_command)
# android-chromium-testshell -> android-chromium-testshell
@@ -268,7 +269,7 @@ vars = {
expected_command = ('tools/perf/run_benchmark -v --browser='
'android-chromium-testshell page_cycler.intl_ja_zh')
self.assertEqual(
- bisect_instance.GetCompatibleCommand(command, git_revision),
+ bisect_instance.GetCompatibleCommand(command, git_revision, depot),
expected_command)
# android-chromium-testshell -> android-chrome-shell
@@ -280,7 +281,7 @@ vars = {
expected_command = ('tools/perf/run_benchmark -v --browser='
'android-chrome-shell page_cycler.intl_ja_zh')
self.assertEqual(
- bisect_instance.GetCompatibleCommand(command, git_revision),
+ bisect_instance.GetCompatibleCommand(command, git_revision, depot),
expected_command)
# android-chrome-shell -> android-chrome-shell
command = ('tools/perf/run_benchmark -v '
@@ -288,7 +289,7 @@ vars = {
expected_command = ('tools/perf/run_benchmark -v --browser='
'android-chrome-shell page_cycler.intl_ja_zh')
self.assertEqual(
- bisect_instance.GetCompatibleCommand(command, git_revision),
+ bisect_instance.GetCompatibleCommand(command, git_revision, depot),
expected_command)
# Not android platform
bisect_instance.opts.target_platform = 'chromium'
@@ -297,7 +298,7 @@ vars = {
expected_command = ('tools/perf/run_benchmark -v --browser='
'release page_cycler.intl_ja_zh')
self.assertEqual(
- bisect_instance.GetCompatibleCommand(command, git_revision),
+ bisect_instance.GetCompatibleCommand(command, git_revision, depot),
expected_command)
if __name__ == '__main__':
« tools/bisect-perf-regression.py ('K') | « tools/bisect-perf-regression.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698