Check for chromium revision instead of dependency module revision.

tools/bisect-perf-regression.py

 #!/usr/bin/env python
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Performance Test Bisect Tool
 
 This script bisects a series of changelists using binary search. It starts at
 a bad revision where a performance metric has regressed, and asks for a last
 known-good revision. It will then binary search across this revision range by
@@ skipping 2218 matching lines @@
 
   def _IsBisectModeUsingMetric(self):
     return self.opts.bisect_mode in [BISECT_MODE_MEAN, BISECT_MODE_STD_DEV]
 
   def _IsBisectModeReturnCode(self):
     return self.opts.bisect_mode in [BISECT_MODE_RETURN_CODE]
 
   def _IsBisectModeStandardDeviation(self):
     return self.opts.bisect_mode in [BISECT_MODE_STD_DEV]
 
-  def GetCompatibleCommand(self, command_to_run, revision):
+  def GetCompatibleCommand(self, command_to_run, revision, depot):

[qyearsley, 2014/07/24 00:03:18]

Note -- this function does a very specific thing (it changes the browser in the
telemetry command if the Chromium SVN revision is in a particular range), so
maybe it should have a more specific name, like
"_MaybeChangeTelemetryBrowserForAndroid" (You don't have to use that name,
that's just an example).

[prasadv, 2014/07/24 00:13:06]

Initial thought was to include all compatible related issues in this function.
Since we have seen bisect break when things change, so in order to support
backward compatibility I use GetCompatibleCommand().

On 2014/07/24 00:03:18, qyearsley wrote:

     # Prior to crrev.com/274857 *only* android-chromium-testshell
     # Then until crrev.com/276628 *both* (android-chromium-testshell and
     # android-chrome-shell) work. After that rev 276628 *only*
     # android-chrome-shell works. bisect-perf-reggresion.py script should
     # handle these cases and set appropriate browser type based on revision.
-    if self.opts.target_platform in ['android', 'android-chrome']:
-      svn_revision = self.source_control.SVNFindRev(revision)
+    if self.opts.target_platform in ['android']:
+      # When its a third_party depot, get the chromium revision.
+      if depot != 'chromium':
+        revision = CheckRunGit(['rev-parse', 'HEAD'], cwd=self.src_cwd).strip()
+      svn_revision = self.source_control.SVNFindRev(revision, cwd=self.src_cwd)
+      if not svn_revision:
+        return command_to_run
       cmd_re = re.compile('--browser=(?P<browser_type>\S+)')
       matches = cmd_re.search(command_to_run)
       if IsStringInt(svn_revision) and matches:
         cmd_browser = matches.group('browser_type')
         if svn_revision <= 274857 and cmd_browser == 'android-chrome-shell':
           return command_to_run.replace(cmd_browser,
                                         'android-chromium-testshell')
         elif (svn_revision >= 276628 and
               cmd_browser == 'android-chromium-testshell'):
           return command_to_run.replace(cmd_browser,
@@ skipping 375 matching lines @@
       success = self.RunPostSync(depot)
       if success:
         if skippable and self.ShouldSkipRevision(depot, revision):
           return ('Skipped revision: [%s]' % str(revision),
               BUILD_RESULT_SKIPPED)
 
         start_build_time = time.time()
         if self.BuildCurrentRevision(depot, revision):
           after_build_time = time.time()
           # Hack to support things that got changed.
-          command_to_run = self.GetCompatibleCommand(command_to_run, revision)
+          command_to_run = self.GetCompatibleCommand(
+              command_to_run, revision, depot)
           results = self.RunPerformanceTestAndParseResults(command_to_run,
                                                            metric)
           # Restore build output directory once the tests are done, to avoid
           # any descrepancy.
           if self.IsDownloadable(depot) and revision:
             self.BackupOrRestoreOutputdirectory(restore=True)
 
           if results[1] == 0:
             external_revisions = self.Get3rdPartyRevisionsFromCurrentRevision(
                 depot, revision)
@@ skipping 1523 matching lines @@
       # The perf dashboard scrapes the "results" step in order to comment on
       # bugs. If you change this, please update the perf dashboard as well.
       bisect_utils.OutputAnnotationStepStart('Results')
     print 'Error: %s' % e.message
     if opts.output_buildbot_annotations:
       bisect_utils.OutputAnnotationStepClosed()
   return 1
 
 if __name__ == '__main__':
   sys.exit(main())