Check for chromium revision instead of dependency module revision.

Check for chromium revision instead of dependency module revision.

GetCompatibleCommand checks chromium revision to set appropriate browser type.
While processing 3rd party repositories by bisect, it was trying to compare dependency module
revision instead of chromium revision.

BUG=388411
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285103

[qyearsley, 2014-07-24 00:03:18]

LGTM; I have a suggestion regarding the naming of the function
GetCompatibleCommand, but I'm also OK with submitting this CL as-is.

https://codereview.chromium.org/414893002/diff/40001/tools/bisect-perf-regres...
File tools/bisect-perf-regression.py (right):

https://codereview.chromium.org/414893002/diff/40001/tools/bisect-perf-regres...
tools/bisect-perf-regression.py:2239: def GetCompatibleCommand(self,
command_to_run, revision, depot):
Note -- this function does a very specific thing (it changes the browser in the
telemetry command if the Chromium SVN revision is in a particular range), so
maybe it should have a more specific name, like
"_MaybeChangeTelemetryBrowserForAndroid" (You don't have to use that name,
that's just an example).

[prasadv, 2014-07-24 00:13:06]

https://codereview.chromium.org/414893002/diff/40001/tools/bisect-perf-regres...
File tools/bisect-perf-regression.py (right):

https://codereview.chromium.org/414893002/diff/40001/tools/bisect-perf-regres...
tools/bisect-perf-regression.py:2239: def GetCompatibleCommand(self,
command_to_run, revision, depot):
Initial thought was to include all compatible related issues in this function.
Since we have seen bisect break when things change, so in order to support
backward compatibility I use GetCompatibleCommand().

On 2014/07/24 00:03:18, qyearsley wrote:
> Note -- this function does a very specific thing (it changes the browser in
the
> telemetry command if the Chromium SVN revision is in a particular range), so
> maybe it should have a more specific name, like
> "_MaybeChangeTelemetryBrowserForAndroid" (You don't have to use that name,
> that's just an example).

[prasadv, 2014-07-24 00:16:50]

The CQ bit was checked by prasadv@chromium.org

[commit-bot: I haz the power, 2014-07-24 00:21:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/prasadv@chromium.org/414893002/40001

[commit-bot: I haz the power, 2014-07-24 01:14:36]

Change committed as 285103