Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 414843004: [NaCl SDK] nacl_io: fix invalid access to string data. (Closed)

Created:
6 years, 5 months ago by Sam Clegg
Modified:
6 years, 5 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] nacl_io: fix invalid access to string data. The data referenced by c_str() is only valid as long as the std::string is still live, so hold std::string values on the stack. This was causing tests to fail on my Trusty laptop. BUG= R=binji@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285346

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Sam Clegg
6 years, 5 months ago (2014-07-24 01:51:22 UTC) #1
binji
lgtm, but why wasn't this failing anywhere else, I wonder?
6 years, 5 months ago (2014-07-24 17:07:44 UTC) #2
Sam Clegg
The CQ bit was checked by sbc@chromium.org
6 years, 5 months ago (2014-07-24 17:30:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/414843004/1
6 years, 5 months ago (2014-07-24 17:31:32 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 18:24:10 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 19:03:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_swarming/builds/1946)
6 years, 5 months ago (2014-07-24 19:03:34 UTC) #7
Sam Clegg
6 years, 5 months ago (2014-07-24 19:09:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r285346 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698