Add tests for SwipePinchDetector.

Add tests for SwipePinchDetector.

BUG=322095
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285990

[Sergey Ulanov, 2014-07-24 01:22:57]

https://codereview.chromium.org/414843003/diff/20001/remoting/android/javates...
File
remoting/android/javatests/src/org/chromium/chromoting/SwipePinchDetectorTest.java
(right):

https://codereview.chromium.org/414843003/diff/20001/remoting/android/javates...
remoting/android/javatests/src/org/chromium/chromoting/SwipePinchDetectorTest.java:20:
private float mScaledTouchSlop;
better to call it mTouchSlop. The fact that it's scaled is not important here.

https://codereview.chromium.org/414843003/diff/20001/remoting/android/javates...
remoting/android/javatests/src/org/chromium/chromoting/SwipePinchDetectorTest.java:25:
private float mX0;
Can these be stored as MotionEvent.PointerCoords[]?

https://codereview.chromium.org/414843003/diff/20001/remoting/android/javates...
remoting/android/javatests/src/org/chromium/chromoting/SwipePinchDetectorTest.java:113:
/** Verifies that a pinch with one finger stationary is detected. */
Should we also test the case when there are multiple MOVE events and the
threshold is reached only after first event? E.g. one finger is moved in the
first event and second finger is moved after that.

Currently all test send only one MOVE event.

[Lambros, 2014-07-24 23:13:42]

https://codereview.chromium.org/414843003/diff/20001/remoting/android/javates...
File
remoting/android/javatests/src/org/chromium/chromoting/SwipePinchDetectorTest.java
(right):

https://codereview.chromium.org/414843003/diff/20001/remoting/android/javates...
remoting/android/javatests/src/org/chromium/chromoting/SwipePinchDetectorTest.java:20:
private float mScaledTouchSlop;
On 2014/07/24 01:22:57, Sergey Ulanov wrote:
> better to call it mTouchSlop. The fact that it's scaled is not important here.

Done.

https://codereview.chromium.org/414843003/diff/20001/remoting/android/javates...
remoting/android/javatests/src/org/chromium/chromoting/SwipePinchDetectorTest.java:25:
private float mX0;
On 2014/07/24 01:22:57, Sergey Ulanov wrote:
> Can these be stored as MotionEvent.PointerCoords[]?

Done.

https://codereview.chromium.org/414843003/diff/20001/remoting/android/javates...
remoting/android/javatests/src/org/chromium/chromoting/SwipePinchDetectorTest.java:113:
/** Verifies that a pinch with one finger stationary is detected. */
On 2014/07/24 01:22:57, Sergey Ulanov wrote:
> Should we also test the case when there are multiple MOVE events and the
> threshold is reached only after first event? E.g. one finger is moved in the
> first event and second finger is moved after that.
> 
> Currently all test send only one MOVE event.

Added more gradual-movement tests.

[Sergey Ulanov, 2014-07-28 18:05:47]

lgtm

[Lambros, 2014-07-28 19:59:26]

The CQ bit was checked by lambroslambrou@chromium.org

[commit-bot: I haz the power, 2014-07-28 20:35:48]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/414843003/...

[commit-bot: I haz the power, 2014-07-28 21:56:39]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[commit-bot: I haz the power, 2014-07-28 22:02:26]

Change committed as 285990