Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 414833004: [usb_gadget p08] Package the USB gadget framework for easy distribution. (Closed)

Created:
6 years, 5 months ago by Reilly Grant (use Gerrit)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[usb_gadget p08] Package the USB gadget framework for easy distribution. This software package will need to be uploaded to the test hardware. Python can easily run code out of a zip file. The package hash is saved to verify integrity and as a versioning mechanism to allow tests to ensure that they are running against a device with the expected software version. BUG=396682 R=rockot@chromium.org,rpaquay@chromium.org,kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285513

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -0 lines) Patch
A tools/usb_gadget.gyp View 1 chunk +50 lines, -0 lines 2 comments Download
A tools/usb_gadget/package.py View 1 chunk +68 lines, -0 lines 0 comments Download
M tools/usb_gadget/server.py View 3 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Reilly Grant (use Gerrit)
6 years, 5 months ago (2014-07-24 01:35:22 UTC) #1
Ken Rockot(use gerrit already)
lgtm
6 years, 5 months ago (2014-07-24 03:33:56 UTC) #2
Reilly Grant (use Gerrit)
The CQ bit was checked by reillyg@chromium.org
6 years, 5 months ago (2014-07-24 23:54:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reillyg@chromium.org/414833004/1
6 years, 5 months ago (2014-07-24 23:55:57 UTC) #4
commit-bot: I haz the power
Change committed as 285513
6 years, 5 months ago (2014-07-25 07:04:30 UTC) #5
tfarina
6 years, 3 months ago (2014-08-29 15:42:06 UTC) #6
Message was sent while issue was closed.
after-the-fact comments.

Please, consider addressing them.

https://codereview.chromium.org/414833004/diff/1/tools/usb_gadget.gyp
File tools/usb_gadget.gyp (right):

https://codereview.chromium.org/414833004/diff/1/tools/usb_gadget.gyp#newcode1
tools/usb_gadget.gyp:1: # Copyright 2014 The Chromium Authors. All rights
reserved.
I think this file should have been added to tools/usb_gadget/ directory, rather
to be in tools/

It would be more inline with GN, as you would have:

tools/usb_gadget/BUILD.gn

and targets depending on it "//tools/usb_gadget"

https://codereview.chromium.org/414833004/diff/1/tools/usb_gadget.gyp#newcode6
tools/usb_gadget.gyp:6: 'variables': {
optional (just showing there is other way):

this could be declared inside the targets below.

like:

'target_name': 'usb_gadget',
'type': 'none',
'variables': {
}

Powered by Google App Engine
This is Rietveld 408576698