android_webview/webview_pak.mk - Issue 414823002: [android_webview] Don't unconditionally add pak files to system image.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: android_webview/webview_pak.mk

Issue 414823002: [android_webview] Don't unconditionally add pak files to system image. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 # This makefile fragment describes how to install a Chromium pak into the	5 # This makefile fragment describes how to install a Chromium pak into the

6 # Android framework for use by WebView.	6 # Android framework for use by WebView.

7	7

	8 my_local_module := $(LOCAL_MODULE)

	9 my_local_module_stem := $(LOCAL_MODULE_STEM)

	10 my_local_built_module_stem := $(LOCAL_BUILT_MODULE_STEM)

	11

8 LOCAL_MODULE_CLASS := GYP	12 LOCAL_MODULE_CLASS := GYP

9 LOCAL_MODULE_SUFFIX := .pak	13 LOCAL_MODULE_SUFFIX := .pak

10 LOCAL_MODULE_PATH := $(TARGET_OUT_JAVA_LIBRARIES)/webview/paks	14 LOCAL_MODULE_PATH := $(TARGET_OUT_JAVA_LIBRARIES)/webview/paks

11	15

12 include $(BUILD_SYSTEM)/base_rules.mk	16 include $(BUILD_SYSTEM)/base_rules.mk

13	17

14 built_by_gyp := $(call intermediates-dir-for,GYP,shared)/$(LOCAL_BUILT_MODULE_ST EM)	18 built_by_gyp := $(call intermediates-dir-for,GYP,shared)/$(LOCAL_BUILT_MODULE_ST EM)

15	19

16 $(eval $(call copy-one-file,$(built_by_gyp),$(LOCAL_BUILT_MODULE)))	20 $(eval $(call copy-one-file,$(built_by_gyp),$(LOCAL_BUILT_MODULE)))

	21

	22 include $(CLEAR_VARS)
	Primiano Tucci (use gerrit) 2014/07/28 08:01:02 Can you please add a comment before lines 8 and 22 Can you please add a comment before lines 8 and 22, just to explain what these two rules are doing and where are they copying to? something like: # Copies the ???.pak into out/target/product/foo/system/frameworks/webview/paks/en.pak mkosiba (inactive) 2014/07/28 09:36:08 Done. Show quoted text On 2014/07/28 08:01:02, Primiano Tucci wrote: > Can you please add a comment before lines 8 and 22, just to explain what these > two rules are doing and where are they copying to? something like: > # Copies the ???.pak into > out/target/product/foo/system/frameworks/webview/paks/en.pak Done.
	23

	24 LOCAL_MODULE := res-$(my_local_module)

	25 LOCAL_MODULE_STEM := $(my_local_module_stem)

	26 LOCAL_BUILT_MODULE_STEM := $(my_local_built_module_stem)

	27 LOCAL_MODULE_CLASS := GYP

	28 LOCAL_MODULE_SUFFIX := .pak

	29 LOCAL_MODULE_PATH := $(call intermediates-dir-for,APPS,webviewchromium-paks)

	30

	31 include $(BUILD_SYSTEM)/base_rules.mk

	32

	33 built_by_gyp := $(call intermediates-dir-for,GYP,shared)/$(LOCAL_BUILT_MODULE_ST EM)

	34

	35 $(eval $(call copy-one-file,$(built_by_gyp),$(LOCAL_BUILT_MODULE)))

OLD	NEW

« android_webview/build/resources_config.mk ('K') | « android_webview/build/resources_config.mk ('k') | no next file » | no next file with comments »