content/renderer/pepper/pepper_media_stream_track_host_base.cc - Issue 414643003: Support configuring the audio buffer duration in the Pepper MediaStream API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_media_stream_track_host_base.cc

Issue 414643003: Support configuring the audio buffer duration in the Pepper MediaStream API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tests! Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/pepper/pepper_media_stream_audio_track_host.cc ('K') | « content/renderer/pepper/pepper_media_stream_audio_track_host.cc ('k') | ppapi/proxy/media_stream_audio_track_resource.cc » ('j') | ppapi/tests/test_media_stream_audio_track.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/pepper/pepper_media_stream_track_host_base.cc

diff --git a/content/renderer/pepper/pepper_media_stream_track_host_base.cc b/content/renderer/pepper/pepper_media_stream_track_host_base.cc

index 9ad40a9cf08f8de9ce4f9839ae8a934b1fbc09d2..fa400bf2e5a3ecfe6a049d82070d5be291ef7daa 100644

--- a/content/renderer/pepper/pepper_media_stream_track_host_base.cc

+++ b/content/renderer/pepper/pepper_media_stream_track_host_base.cc

@@ -38,6 +38,8 @@ bool PepperMediaStreamTrackHostBase::InitBuffers(int32_t number_of_buffers,

static_cast<int32_t>(sizeof(ppapi::MediaStreamBuffer::Header)));

// Make each buffer 4 byte aligned.

base::CheckedNumeric<int32_t> buffer_size_aligned = buffer_size;

+ // TODO(amistry): "buffer size" should not == "buffer stride", in the same way

+ // that width != stride in an image buffer.

dmichael (off chromium) 2014/07/23 20:08:42 "should not"... do you mean "might not"?

Anand Mistry (off Chromium) 2014/07/24 01:28:28 Yes. Well, and logically, the two should probably

buffer_size_aligned += (4 - buffer_size % 4);

// TODO(penghuang): |HostAllocateSharedMemoryBuffer| uses sync IPC. We should