ppapi/proxy/media_stream_audio_track_resource.cc - Issue 414643003: Support configuring the audio buffer duration in the Pepper MediaStream API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/proxy/media_stream_audio_track_resource.cc

Issue 414643003: Support configuring the audio buffer duration in the Pepper MediaStream API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add clarifying comment about buffer size. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/pepper/pepper_media_stream_audio_track_host.cc ('K') | « content/renderer/pepper/pepper_media_stream_track_host_base.cc ('k') | ppapi/proxy/ppapi_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ppapi/proxy/media_stream_audio_track_resource.cc

diff --git a/ppapi/proxy/media_stream_audio_track_resource.cc b/ppapi/proxy/media_stream_audio_track_resource.cc

index 32fdd2846fe7a53f562481f4dec18472ecf0eb5b..5d30362414ebec73452f6a9f17550c5c464ecb77 100644

--- a/ppapi/proxy/media_stream_audio_track_resource.cc

+++ b/ppapi/proxy/media_stream_audio_track_resource.cc

@@ -62,10 +62,12 @@ int32_t MediaStreamAudioTrackResource::Configure(

case PP_MEDIASTREAMAUDIOTRACK_ATTRIB_BUFFERS:

attributes.buffers = attrib_list[i + 1];

break;

+ case PP_MEDIASTREAMAUDIOTRACK_ATTRIB_DURATION:

+ attributes.duration = attrib_list[i + 1];

+ break;

case PP_MEDIASTREAMAUDIOTRACK_ATTRIB_SAMPLE_RATE:

case PP_MEDIASTREAMAUDIOTRACK_ATTRIB_SAMPLE_SIZE:

case PP_MEDIASTREAMAUDIOTRACK_ATTRIB_CHANNELS:

- case PP_MEDIASTREAMAUDIOTRACK_ATTRIB_DURATION:

return PP_ERROR_NOTSUPPORTED;

default:

return PP_ERROR_BADARGUMENT;