Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 414633003: Mojo: Set a default value for the --origin command line switch. (Closed)

Created:
6 years, 5 months ago by darin (slow to review)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mojo: Set a default value for the --origin command line switch. (Also fixes a regression in the wget app.) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285668

Patch Set 1 #

Total comments: 1

Patch Set 2 : refactored #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -14 lines) Patch
M mojo/examples/wget/wget.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/mojo_url_resolver.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M mojo/shell/mojo_url_resolver.cc View 1 3 chunks +19 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
darin (slow to review)
Tim, I know this CL conflicts with https://codereview.chromium.org/397733003/, and I'm happy to rebase this change ...
6 years, 5 months ago (2014-07-23 03:27:11 UTC) #1
tim (not reviewing)
LGTM, it wouldn't be the end of the world if I had to rebase on ...
6 years, 5 months ago (2014-07-23 22:22:32 UTC) #2
tim (not reviewing)
On 2014/07/23 22:22:32, timsteele wrote: > LGTM, it wouldn't be the end of the world ...
6 years, 5 months ago (2014-07-23 22:23:53 UTC) #3
darin (slow to review)
@tim - PTAL This version is like what we discussed.
6 years, 5 months ago (2014-07-25 17:12:59 UTC) #4
tim (not reviewing)
LGTM
6 years, 5 months ago (2014-07-25 17:28:51 UTC) #5
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 5 months ago (2014-07-25 17:45:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/414633003/20001
6 years, 5 months ago (2014-07-25 17:47:47 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 20:41:57 UTC) #8
Message was sent while issue was closed.
Change committed as 285668

Powered by Google App Engine
This is Rietveld 408576698