Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4318)

Unified Diff: chrome/browser/printing/print_preview_pdf_generated_browsertest.cc

Issue 414623005: PrintPreviewPdfGeneratedBrowserTest properly listens to messages and exits correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added comment on exit condition for the test. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/print_preview_pdf_generated_browsertest.cc
diff --git a/chrome/browser/printing/print_preview_pdf_generated_browsertest.cc b/chrome/browser/printing/print_preview_pdf_generated_browsertest.cc
index f8dd016d8476c5926f51517be79752c56119d139..72dad06ffdbe239c886b900fc4b963feba375d5e 100644
--- a/chrome/browser/printing/print_preview_pdf_generated_browsertest.cc
+++ b/chrome/browser/printing/print_preview_pdf_generated_browsertest.cc
@@ -644,25 +644,19 @@ IN_PROC_BROWSER_TEST_F(PrintPreviewPdfGeneratedBrowserTest,
InitPdfFunctions();
SetupStdinAndSavePath();
- // There is no way to determine how many tests are to be run ahead of time
- // without undesirable changes to the layout test framework. However, that is
- // ok since whenever all the tests have been run, the layout test framework
- // calls SIGKILL on this process, ending the test. This will end the while
- // loop and cause the test to clean up after itself. For this to work, the
- // browsertest must be run with '--single_process' not '--single-process.'
while (true) {
std::string input;
- std::getline(std::cin, input);
- if (input.empty()) {
- while (std::cin.eof()) {
+ while (input.empty()) {
+ std::getline(std::cin, input);
+ if (std::cin.eof())
std::cin.clear();
- std::getline(std::cin, input);
- if (!input.empty()) {
- break;
- }
- }
}
+ // If the layout test framework sends "QUIT" to this test, that means there
+ // are no more tests for this instance to run and it should quit.
+ if (input == "QUIT")
+ break;
+
base::FilePath::StringType file_extension = FILE_PATH_LITERAL(".pdf");
base::FilePath::StringType cmd;
#if defined(OS_POSIX)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698