Video Player: Use external entries instead of isolated entries

Video Player: Use external entries instead of isolated entries

This patch migrates entries to external entries, as preparation for taking an advantage of external entries.

BUG=none
TEST=video player works
R=hirono@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284903

[yoshiki, 2014-07-23 02:19:10]

@hirono, PTAL. Thanks

[hirono, 2014-07-23 02:48:58]

https://codereview.chromium.org/414623003/diff/20001/ui/file_manager/video_pl...
File ui/file_manager/video_player/js/background.js (right):

https://codereview.chromium.org/414623003/diff/20001/ui/file_manager/video_pl...
ui/file_manager/video_player/js/background.js:29:
chrome.app.runtime.onLaunched.addListener(onLaunched);
I'm not sure if it is OK to register the onLaunched handler asynchronously.
What happens when the background page is launched by the launched event?

https://codereview.chromium.org/414623003/diff/20001/ui/file_manager/video_pl...
ui/file_manager/video_player/js/background.js:60: });
Should wrap here?

[yoshiki, 2014-07-23 03:49:40]

@hirono, PTAL.

https://codereview.chromium.org/414623003/diff/20001/ui/file_manager/video_pl...
File ui/file_manager/video_player/js/background.js (right):

https://codereview.chromium.org/414623003/diff/20001/ui/file_manager/video_pl...
ui/file_manager/video_player/js/background.js:29:
chrome.app.runtime.onLaunched.addListener(onLaunched);
On 2014/07/23 02:48:58, hirono wrote:
> I'm not sure if it is OK to register the onLaunched handler asynchronously.
> What happens when the background page is launched by the launched event?

I'm also not sure but I think it's better to care. Fixed.

https://codereview.chromium.org/414623003/diff/20001/ui/file_manager/video_pl...
ui/file_manager/video_player/js/background.js:60: });
On 2014/07/23 02:48:58, hirono wrote:
> Should wrap here?

Done.

[hirono, 2014-07-23 04:19:13]

lgtm with a nit.

https://codereview.chromium.org/414623003/diff/40001/ui/file_manager/video_pl...
File ui/file_manager/video_player/js/background.js (right):

https://codereview.chromium.org/414623003/diff/40001/ui/file_manager/video_pl...
ui/file_manager/video_player/js/background.js:47: return {
nit: Can we do object.freeze?

[yoshiki, 2014-07-23 05:01:34]

The CQ bit was checked by yoshiki@chromium.org

[yoshiki, 2014-07-23 05:01:54]

https://codereview.chromium.org/414623003/diff/40001/ui/file_manager/video_pl...
File ui/file_manager/video_player/js/background.js (right):

https://codereview.chromium.org/414623003/diff/40001/ui/file_manager/video_pl...
ui/file_manager/video_player/js/background.js:47: return {
On 2014/07/23 04:19:13, hirono wrote:
> nit: Can we do object.freeze?

Done.

[commit-bot: I haz the power, 2014-07-23 05:03:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yoshiki@chromium.org/414623003/60001

[commit-bot: I haz the power, 2014-07-23 10:00:39]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-07-23 10:38:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-23 10:38:03]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[yoshiki, 2014-07-23 11:20:35]

Committed patchset #3 manually as r284903 (presubmit successful).