Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 414623002: Update the tracing grit GN rule (Closed)

Created:
6 years, 5 months ago by brettw
Modified:
6 years, 5 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, darin-cc_chromium.org, dsinclair+watch_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Update the tracing grit GN rule Previously this rule had a lot of custom stuff to work around the fact that the grit rule couldn't run at GN time to get the inputs and outputs. Now that the inputs are lazy, we can use the template. R=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284948

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -30 lines) Patch
M build/secondary/tools/grit/grit_rule.gni View 2 chunks +13 lines, -1 line 0 comments Download
M content/browser/tracing/BUILD.gn View 2 chunks +12 lines, -29 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
6 years, 5 months ago (2014-07-22 23:39:56 UTC) #1
viettrungluu
lgtm
6 years, 5 months ago (2014-07-22 23:56:16 UTC) #2
brettw
6 years, 5 months ago (2014-07-23 16:34:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r284948 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698